From: Jakub Kicinski <kuba@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 26/29] net/tls: use the new scatterwalk functions
Date: Mon, 23 Dec 2024 12:44:31 -0800 [thread overview]
Message-ID: <20241223124431.1d34888f@kernel.org> (raw)
In-Reply-To: <20241223194249.GB2032@quark.localdomain>
On Mon, 23 Dec 2024 11:42:49 -0800 Eric Biggers wrote:
> > Acked-by: Jakub Kicinski <kuba@kernel.org>
>
> Thanks. FYI I will need to update this patch in the next version, as I did not
> take into consideration what chain_to_walk() is doing. This code seems to be a
> bit unique in how it is using the scatterwalk functions.
>
> Also I think the second paragraph of my commit message is wrong, as the calls to
> scatterwalk_done() in tls_enc_records() are the ones I thought were missing.
netdev@ only got CCed on this one patch so TBH I have trusted
the conversion :(
FWIW tls has a relatively solid selftest:
tools/testing/selftests/net/tls.c
next prev parent reply other threads:[~2024-12-23 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241221091056.282098-1-ebiggers@kernel.org>
2024-12-21 9:10 ` [PATCH 26/29] net/tls: use the new scatterwalk functions Eric Biggers
2024-12-23 15:48 ` Jakub Kicinski
2024-12-23 19:42 ` Eric Biggers
2024-12-23 20:44 ` Jakub Kicinski [this message]
2024-12-29 23:58 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223124431.1d34888f@kernel.org \
--to=kuba@kernel.org \
--cc=borisp@nvidia.com \
--cc=ebiggers@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).