From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 589DC1D435F; Mon, 23 Dec 2024 20:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734986462; cv=none; b=YADzhxaxKXhch2PFyMk18ELPSoeRBrrPHWoUlpwHFov0GzQ24TMyT7zXfC+VOf8ZjlqyBEqLEKLXSJwEN6AFJrTm8rPDHcGXta5HkRft88c3TgS8qz4/f/qLtCl0US72KwfVvf+9UaHW6Dt6z+H4MJHtl0ryP6jZDHTDuDhtaE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734986462; c=relaxed/simple; bh=lhQuTDAwMrcuQ0VuSuwjCJBKNUo6+ySBw73n368V6uQ=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LALGcHBQNkiax1IhNidBx5J8m+AHqQYHDpelR2ML7q/ulXHyJRaVz7AiSuJya5NylSIZeN2+9UQlePiCg8uau1RK30d/4JojGEYsSRGXlPWvJXjLlmsloZ+pM5abryXbHPhBD1xAE0al6ymY70WVa0tvQf2az+DaY8YXxUoTvis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YH8yn0rpCz67FbS; Tue, 24 Dec 2024 04:39:45 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 6AA56140A70; Tue, 24 Dec 2024 04:40:57 +0800 (CST) Received: from localhost (10.47.75.118) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 23 Dec 2024 21:40:55 +0100 Date: Mon, 23 Dec 2024 20:40:54 +0000 From: Jonathan Cameron To: Zijun Hu CC: Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , James Bottomley , Thomas =?ISO-8859-1?Q?Wei=DFschu?= =?ISO-8859-1?Q?h?= , , , , , , , , , , , , , , , , , , , , , Zijun Hu Subject: Re: [PATCH v4 06/11] driver core: Remove match_any() Message-ID: <20241223204054.000056db@huawei.com> In-Reply-To: <20241211-const_dfc_done-v4-6-583cc60329df@quicinc.com> References: <20241211-const_dfc_done-v4-0-583cc60329df@quicinc.com> <20241211-const_dfc_done-v4-6-583cc60329df@quicinc.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) On Wed, 11 Dec 2024 08:08:08 +0800 Zijun Hu wrote: > From: Zijun Hu > > Static match_any() is exactly same as API device_match_any(). is now exactly... perhaps to call out that it wasn't prior to this set! > Remove the former and use the later instead. > > Signed-off-by: Zijun Hu Reviewed-by: Jonathan Cameron > --- > drivers/base/core.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 8116bc8dd6e9eba0653ca686a90c7008de9e2840..289f2dafa8f3831931d0f316d66ee12c2cb8a2e1 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -4114,11 +4114,6 @@ struct device *device_find_child_by_name(struct device *parent, > } > EXPORT_SYMBOL_GPL(device_find_child_by_name); > > -static int match_any(struct device *dev, const void *unused) > -{ > - return 1; > -} > - > /** > * device_find_any_child - device iterator for locating a child device, if any. > * @parent: parent struct device > @@ -4130,7 +4125,7 @@ static int match_any(struct device *dev, const void *unused) > */ > struct device *device_find_any_child(struct device *parent) > { > - return device_find_child(parent, NULL, match_any); > + return device_find_child(parent, NULL, device_match_any); > } > EXPORT_SYMBOL_GPL(device_find_any_child); > >