From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E4051B0F1B; Mon, 23 Dec 2024 20:45:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734986724; cv=none; b=g1KrqoT2lWm2asC8c4i9RpC2bZ1z7u5viG/7BGOovLLGxtBnJ/cTs+917Cfl+0OoUi6ng1sph17GqMBN2M5bwbu/qToMntag1yi4CAdk9lXscmvt+/yUlb7gTQAhV/gX8O8TZB3IaVx0X2H+1SYAVDMpoJFNgFjjAh2UTP8QCvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734986724; c=relaxed/simple; bh=H8AxDNILrBFTvWJnUYt02RouJYnj1MLFuMcBGgYdWW8=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rrdiiSY7NzZpLWe08xSNOvD639W6LV5gXdGsEcqWN5wBm+SHFPGnYYjncdLjWOjSD06E9oJKpjzyukL89eO0xCpHkra98LLUz8ndQpqKe2IhZAxPYEUFS5dkjw4WNBg6j5FVmk7yASHB9nNjHkAE3FP4PdZOWHXCl0mT9hVsLiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YH94v6dSXz6K6mq; Tue, 24 Dec 2024 04:45:03 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 6AC22140517; Tue, 24 Dec 2024 04:45:21 +0800 (CST) Received: from localhost (10.47.75.118) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 23 Dec 2024 21:45:20 +0100 Date: Mon, 23 Dec 2024 20:45:18 +0000 From: Jonathan Cameron To: Zijun Hu CC: Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , James Bottomley , Thomas =?ISO-8859-1?Q?Wei=DFschu?= =?ISO-8859-1?Q?h?= , , , , , , , , , , , , , , , , , , , , , Zijun Hu Subject: Re: [PATCH v4 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode() Message-ID: <20241223204518.000003ad@huawei.com> In-Reply-To: <20241211-const_dfc_done-v4-8-583cc60329df@quicinc.com> References: <20241211-const_dfc_done-v4-0-583cc60329df@quicinc.com> <20241211-const_dfc_done-v4-8-583cc60329df@quicinc.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To frapeml500008.china.huawei.com (7.182.85.71) On Wed, 11 Dec 2024 08:08:10 +0800 Zijun Hu wrote: > From: Zijun Hu > > gpio_sim_dev_match_fwnode() is a simple wrapper of API > device_match_fwnode(). > > Remove the needless wrapper and use the API instead. > > Signed-off-by: Zijun Hu Reviewed-by: Jonathan Cameron > --- > drivers/gpio/gpio-sim.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c > index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644 > --- a/drivers/gpio/gpio-sim.c > +++ b/drivers/gpio/gpio-sim.c > @@ -413,11 +413,6 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip) > return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip); > } > > -static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data) > -{ > - return device_match_fwnode(dev, data); > -} > - > static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev) > { > struct gpio_sim_chip *chip; > @@ -503,7 +498,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev) > if (ret) > return ret; > > - chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode); > + chip->dev = device_find_child(dev, swnode, device_match_fwnode); > if (!chip->dev) > return -ENODEV; > >