From: Jakub Kicinski <kuba@kernel.org>
To: John Sperbeck <jsperbeck@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Breno Leitao <leitao@debian.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: netpoll: ensure skb_pool list is always initialized
Date: Mon, 30 Dec 2024 17:57:07 -0800 [thread overview]
Message-ID: <20241230175707.5e18ae96@kernel.org> (raw)
In-Reply-To: <20241222012334.249021-1-jsperbeck@google.com>
On Sat, 21 Dec 2024 17:23:34 -0800 John Sperbeck wrote:
> Move the skb_pool list initialization into __netpoll_setup(). Also,
> have netpoll_setup() call this before allocating its initial pool of
> packets.
>
> Fixes: 6c59f16f1770 ("net: netpoll: flush skb pool during cleanup")
The fixes tag seems to be off by one? Wasn't the problem was introduced
by commit 221a9c1df790 ("net: netpoll: Individualize the skb pool") ?
Since __netpoll_setup() can be called by other drivers, shouldn't
we move refill in there? Since the pool is per np?
Optionally, could you extend the netcons tests to exercise netcons over
vlan? I think it should be able to trigger the crash you're fixing?
--
pw-bot: cr
next prev parent reply other threads:[~2024-12-31 1:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-22 1:23 [PATCH] net: netpoll: ensure skb_pool list is always initialized John Sperbeck
2024-12-31 1:57 ` Jakub Kicinski [this message]
2025-01-03 13:24 ` Breno Leitao
2025-01-10 13:07 ` Breno Leitao
2025-01-11 0:32 ` [PATCH v2] " John Sperbeck
2025-01-13 10:09 ` Breno Leitao
2025-01-14 1:13 ` [PATCH net v3] " John Sperbeck
2025-01-14 10:16 ` Breno Leitao
2025-01-15 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241230175707.5e18ae96@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jsperbeck@google.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).