From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Su Hui <suhui@nfschina.com>
Cc: alexanderduyck@fb.com, kernel-team@meta.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, mohsin.bashr@gmail.com,
sanmanpradhan@meta.com, kalesh-anakkur.purayil@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor_asic()
Date: Fri, 3 Jan 2025 10:07:37 -0800 [thread overview]
Message-ID: <20250103100737.1f329212@kernel.org> (raw)
In-Reply-To: <20241230085249.4aa68872@kernel.org>
On Mon, 30 Dec 2024 08:52:49 -0800 Jakub Kicinski wrote:
> > It is more like removing broken functionality than fixing (maybe whole
> > commit should be reverted). Anyway returning not support is also fine.
>
> I defer to other maintainers. The gaps are trivial to fill in, we'll
> do so as soon as this patch makes it to net-next (this patch needs to
> target net).
Having slept on it, I think you're right.
Su Hui, could you send a revert of d85ebade02e8 instead?
It's around 126 LoC, not too bad.
next prev parent reply other threads:[~2025-01-03 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 1:42 [PATCH v2] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor_asic() Su Hui
2024-12-30 8:00 ` Michal Swiatkowski
2024-12-30 16:52 ` Jakub Kicinski
2025-01-03 18:07 ` Jakub Kicinski [this message]
2025-01-06 1:08 ` Su Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103100737.1f329212@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanmanpradhan@meta.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).