From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Mark Zhang <markzhang@nvidia.com>,
Francesco Poli <invernomuto@paranoici.org>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH mlx5-next] RDMA/mlx5: Enable multiplane mode only when it is supported
Date: Fri, 3 Jan 2025 10:11:17 -0400 [thread overview]
Message-ID: <20250103141117.GA137209@nvidia.com> (raw)
In-Reply-To: <1ef901acdf564716fcf550453cf5e94f343777ec.1734610916.git.leon@kernel.org>
On Thu, Dec 19, 2024 at 02:23:36PM +0200, Leon Romanovsky wrote:
> From: Mark Zhang <markzhang@nvidia.com>
>
> Driver queries vport_cxt.num_plane and enables multiplane when it is
> greater then 0, but some old FWs (versions from x.40.1000 till x.42.1000),
> report vport_cxt.num_plane = 1 unexpectedly.
>
> Fix it by querying num_plane only when HCA_CAP2.multiplane bit is set.
>
> Fixes: 2a5db20fa532 ("RDMA/mlx5: Add support to multi-plane device and port")
> Cc: stable@vger.kernel.org
> Reported-by: Francesco Poli <invernomuto@paranoici.org>
> Closes: https://lore.kernel.org/all/nvs4i2v7o6vn6zhmtq4sgazy2hu5kiulukxcntdelggmznnl7h@so3oul6uwgbl/
> Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 2 +-
> include/linux/mlx5/mlx5_ifc.h | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Applied to for-rc thanks
Jason
prev parent reply other threads:[~2025-01-03 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 12:23 [PATCH mlx5-next] RDMA/mlx5: Enable multiplane mode only when it is supported Leon Romanovsky
2024-12-19 13:23 ` Michal Swiatkowski
2024-12-19 14:01 ` Leon Romanovsky
2025-01-03 14:11 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103141117.GA137209@nvidia.com \
--to=jgg@nvidia.com \
--cc=invernomuto@paranoici.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).