[PATCH net-next v2] bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"

[PATCH net-next v2] bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"

[Ted Chen]

The skb_buff struct in br_is_nd_neigh_msg() is never modified. Mark it as
const.

Signed-off-by: Ted Chen <znscnchen@gmail.com>
---
v2:
- Rebased to net-next (Nicolay)
- Wrapped commit message lines to be within 75 characters. (Nicolay)
- Added net-next to patch subject. (Nicolay)

v1:
https://lore.kernel.org/all/20250103070900.70014-1-znscnchen@gmail.com
---
 net/bridge/br_arp_nd_proxy.c | 2 +-
 net/bridge/br_private.h      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bridge/br_arp_nd_proxy.c b/net/bridge/br_arp_nd_proxy.c
index c7869a286df4..115a23054a58 100644
--- a/net/bridge/br_arp_nd_proxy.c
+++ b/net/bridge/br_arp_nd_proxy.c
@@ -229,7 +229,7 @@ void br_do_proxy_suppress_arp(struct sk_buff *skb, struct net_bridge *br,
 #endif
 
 #if IS_ENABLED(CONFIG_IPV6)
-struct nd_msg *br_is_nd_neigh_msg(struct sk_buff *skb, struct nd_msg *msg)
+struct nd_msg *br_is_nd_neigh_msg(const struct sk_buff *skb, struct nd_msg *msg)
 {
 	struct nd_msg *m;
 
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 29d6ec45cf41..1054b8a88edc 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -2299,6 +2299,6 @@ void br_do_proxy_suppress_arp(struct sk_buff *skb, struct net_bridge *br,
 			      u16 vid, struct net_bridge_port *p);
 void br_do_suppress_nd(struct sk_buff *skb, struct net_bridge *br,
 		       u16 vid, struct net_bridge_port *p, struct nd_msg *msg);
-struct nd_msg *br_is_nd_neigh_msg(struct sk_buff *skb, struct nd_msg *m);
+struct nd_msg *br_is_nd_neigh_msg(const struct sk_buff *skb, struct nd_msg *m);
 bool br_is_neigh_suppress_enabled(const struct net_bridge_port *p, u16 vid);
 #endif
-- 
2.39.2

Re: [PATCH net-next v2] bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"

[Nikolay Aleksandrov]

On 1/4/25 10:38, Ted Chen wrote:
> The skb_buff struct in br_is_nd_neigh_msg() is never modified. Mark it as
> const.
> 
> Signed-off-by: Ted Chen <znscnchen@gmail.com>
> ---
> v2:
> - Rebased to net-next (Nicolay)
> - Wrapped commit message lines to be within 75 characters. (Nicolay)
> - Added net-next to patch subject. (Nicolay)
> 
> v1:
> https://lore.kernel.org/all/20250103070900.70014-1-znscnchen@gmail.com
> ---

Acked-by: Nikolay Aleksandrov <razor@blackwall.org>

Re: [PATCH net-next v2] bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Sat,  4 Jan 2025 16:38:46 +0800 you wrote:
> The skb_buff struct in br_is_nd_neigh_msg() is never modified. Mark it as
> const.
> 
> Signed-off-by: Ted Chen <znscnchen@gmail.com>
> ---
> v2:
> - Rebased to net-next (Nicolay)
> - Wrapped commit message lines to be within 75 characters. (Nicolay)
> - Added net-next to patch subject. (Nicolay)
> 
> [...]

Here is the summary with links:
  - [net-next,v2] bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"
    https://git.kernel.org/netdev/net-next/c/a1942da8a387

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html