From: Jakub Kicinski <kuba@kernel.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: M Chetan Kumar <m.chetan.kumar@intel.com>,
Loic Poulain <loic.poulain@linaro.org>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: wwan: iosm: Fix hibernation by re-binding the driver around it
Date: Sat, 4 Jan 2025 08:48:46 -0800 [thread overview]
Message-ID: <20250104084846.300455d4@kernel.org> (raw)
In-Reply-To: <ea5c805559e842077734a6c7695dd60467c1ef12.1735490770.git.mail@maciej.szmigiero.name>
On Sun, 29 Dec 2024 17:46:59 +0100 Maciej S. Szmigiero wrote:
> + if (pci_registered)
> + pci_unregister_driver(&iosm_ipc_driver);
> +
> + unregister_pm_notifier(&pm_notifier);
The ordering here should be inverted so that you're sure notifier can't
run in parallel.
But I think the notifier is an overkill, there's gotta be an op that
runs. pci_driver::shutdown ? dev_pm_ops::freeze / thaw ?
If you repost please make sure to CC the PCI list, folks there will
know how hibernation is supposed to be handled for sure. Note that
patch 1 is already in Linus's tree so repost just patch 2.
next prev parent reply other threads:[~2025-01-04 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 16:46 [PATCH 1/2] net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init() Maciej S. Szmigiero
2024-12-29 16:46 ` [PATCH 2/2] net: wwan: iosm: Fix hibernation by re-binding the driver around it Maciej S. Szmigiero
2025-01-04 16:48 ` Jakub Kicinski [this message]
2025-01-03 2:50 ` [PATCH 1/2] net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250104084846.300455d4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=mail@maciej.szmigiero.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).