[PATCH net-next] eth: fbnic: update fbnic_poll return value

[PATCH net-next] eth: fbnic: update fbnic_poll return value

[Mohsin Bashir]

In cases where the work done is less than the budget, `fbnic_poll` is
returning 0. This affects the tracing of `napi_poll`. Following is a
snippet of before and after result from `napi_poll` tracepoint. Instead,
returning the work done improves the manual tracing.

Before:
@[10]: 1
...
@[64]: 208175
@[0]: 2128008

After:
@[56]: 86
@[48]: 222
...
@[5]: 1885756
@[6]: 1933841

Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
index bb54ce5f5787..d4d7027df9a0 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
@@ -1033,7 +1033,7 @@ static int fbnic_poll(struct napi_struct *napi, int budget)
 	if (likely(napi_complete_done(napi, work_done)))
 		fbnic_nv_irq_rearm(nv);
 
-	return 0;
+	return work_done;
 }
 
 irqreturn_t fbnic_msix_clean_rings(int __always_unused irq, void *data)
-- 
2.43.5

Re: [PATCH net-next] eth: fbnic: update fbnic_poll return value

[Jakub Kicinski]

On Fri,  3 Jan 2025 17:53:16 -0800 Mohsin Bashir wrote:
> In cases where the work done is less than the budget, `fbnic_poll` is
> returning 0. This affects the tracing of `napi_poll`. Following is a
> snippet of before and after result from `napi_poll` tracepoint. Instead,
> returning the work done improves the manual tracing.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Re: [PATCH net-next] eth: fbnic: update fbnic_poll return value

[Kalesh Anakkur Purayil]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

On Sat, Jan 4, 2025 at 7:23 AM Mohsin Bashir <mohsin.bashr@gmail.com> wrote:
>
> In cases where the work done is less than the budget, `fbnic_poll` is
> returning 0. This affects the tracing of `napi_poll`. Following is a
> snippet of before and after result from `napi_poll` tracepoint. Instead,
> returning the work done improves the manual tracing.
>
> Before:
> @[10]: 1
> ...
> @[64]: 208175
> @[0]: 2128008
>
> After:
> @[56]: 86
> @[48]: 222
> ...
> @[5]: 1885756
> @[6]: 1933841
>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

-- 
Regards,
Kalesh AP

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]

Re: [PATCH net-next] eth: fbnic: update fbnic_poll return value

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri,  3 Jan 2025 17:53:16 -0800 you wrote:
> In cases where the work done is less than the budget, `fbnic_poll` is
> returning 0. This affects the tracing of `napi_poll`. Following is a
> snippet of before and after result from `napi_poll` tracepoint. Instead,
> returning the work done improves the manual tracing.
> 
> Before:
> @[10]: 1
> ...
> @[64]: 208175
> @[0]: 2128008
> 
> [...]

Here is the summary with links:
  - [net-next] eth: fbnic: update fbnic_poll return value
    https://git.kernel.org/netdev/net-next/c/2f4f8893e07a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html