From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C345D846D; Sat, 4 Jan 2025 22:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736029449; cv=none; b=OnNhGVIkBy4r4Yhpn4ChICmoOO+FHDpegVC3x3fyuTV3zLyQOlVtyufzZNyl+Wo8CrdOgxT5wGlvl2RmwWmp2mDcZU4YYatad5N08aRMUIvN7P9sedYoSjnr9K2RfFTTCuc6TxYhUdiOBCU2GwAf1xjJrC32jXTPX4UxZIWXp8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736029449; c=relaxed/simple; bh=mJP7MmymDvBHuu3GkGqqjffvuPPCe6EPotolqP1uAhg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G5e25RaTQU2yJ2ZJGPQYOHotXHLtotYGv+IRYRpeyIp9eeUOSbPLXkU/jyZt/7PcCrIHUBgvFf5kGWC3zzN8LGRmLCKFWCi1wD2DH3C4h6RHWdskwX6yrhFMsYWeNEpJufrCfyl7wWBYHt5Ngy16nH/itxCXWii9RGzvBuK6sGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dozAWfMD; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dozAWfMD" Received: by mail.gandi.net (Postfix) with ESMTPSA id 36F0260002; Sat, 4 Jan 2025 22:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736029444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czvChNqrTnVqBrG36tMy4XATCviKEogNfCQw5FJmBGs=; b=dozAWfMDXRguNqllDMrxQa8OYymXUBIYiRVahigFVYfExjNGvrIpIRVnZat+EQZFoijqZD wnNyMFaf+ICZv/iuLiwg7GWT6KphiCRUZt3z7CRUrw8A8GeTYL1/OeShn1QRuyD2ppcDfy RyjDFmk9btDc3U542HVWQnCLxKsZswYuVDBB/AHGFigfl2GpPD6YPfg+xk8f6VcYvd3A4y AqfB/f53LSSdwIsBpU2IhgQDuK6Q/mJFEFt61eGTdka9xjrvgsVona0e9YTNhAgud+MPkV w2qz8QbMVx6N19cG2IkhgWXybXPiMMZCHW9dW8d+2y3uYqiFPXZM0IxCNwUF8g== Date: Sat, 4 Jan 2025 23:23:59 +0100 From: Kory Maincent To: Oleksij Rempel Cc: Maxime Chevallier , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Marek =?UTF-8?B?QmVow7pu?= , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart Subject: Re: [PATCH net-next RFC 0/5] net: phy: Introduce a port representation Message-ID: <20250104232359.2c7a7090@kmaincent-XPS-13-7390> In-Reply-To: References: <20241220201506.2791940-1-maxime.chevallier@bootlin.com> Organization: bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com On Sun, 22 Dec 2024 19:54:37 +0100 Oleksij Rempel wrote: > transformer { > model =3D "ABC123"; /* Transformer model number */ > manufacturer =3D "TransformerCo"; /* Manufacturer name */ >=20 > pairs { > pair@0 { > name =3D "A"; /* Pair A */ > pins =3D <1 2>; /* Connector pins */ > phy-mapping =3D ; /* PHY pin map= ping */ > center-tap =3D "CT0"; /* Central tap identifier */ > /* if pse-positive and pse-negative are present - > polarity is configurable */ pse-positive =3D ; /* PSE-control= led > positive pin -> CT0 */ pse-negative =3D ; /* PSE-controlled > negative pin -> CT0 */ }; > pair@1 { > name =3D "B"; /* Pair B */ > pins =3D <3 6>; /* Connector pins */ > phy-mapping =3D ; > center-tap =3D "CT1"; /* Central tap identifier */ > pse-positive =3D ; > pse-negative =3D ; > }; > pair@2 { > name =3D "C"; /* Pair C */ > pins =3D <4 5>; /* Connector pins */ > phy-mapping =3D ; /* PHY > connection only */ center-tap =3D "CT2"; /* Central tap identifier */ > pse-positive =3D ; > pse-negative =3D ; > }; > pair@3 { > name =3D "D"; /* Pair D */ > pins =3D <7 8>; /* Connector pins */ > phy-mapping =3D ; /* PHY > connection only */ center-tap =3D "CT3"; /* Central tap identifier */ > pse-positive =3D ; > pse-negative =3D ; > }; > }; > }; >=20 > pse =3D <&pse1>; /* Reference to the attached PSE controller */ The PSE pairset and polarity are already described in the PSE bindings. https://elixir.bootlin.com/linux/v6.12.6/source/Documentation/devicetree/bi= ndings/net/pse-pd/pse-controller.yaml I am not sure it is a good idea to have PSE information at two different pl= aces. > leds { > ethernet-leds { > link =3D <ð_led0>; /* Link status LED */ > activity =3D <ð_led1>; /* Activity LED */ > speed =3D <ð_led2>; /* Speed indication LED */ > }; >=20 > poe-leds { > power =3D <&poe_led0>; /* PoE power status LED */ > fault =3D <&poe_led1>; /* PoE fault indication LED */ > budget =3D <&poe_led2>; /* PoE budget usage LED */ > }; > }; Maybe the PoE leds should also land in our pse-pis binding. > In case of PoDL, we will have something like this: >=20 > pair@0 { > name =3D "A"; /* Single pair for 10BaseT1L */ > pins =3D <1 2>; /* Connector pins */ > phy-mapping =3D ; /* PHY pin mapping */ > podl-mapping =3D ; /* PoDL mapping: Positive= and > negative outputs */ }; We should do the same for PoDL. Put all information in the same place, the = PSE bindings. Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com