From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31FA0182D0; Sun, 5 Jan 2025 11:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736076595; cv=none; b=B2SkvxDCslltMAhbHyXedMXRpqgRlZ8BN22xlc8PPnwUPHJ/0RJ747hCXwhzxgmZu1kYw9EsaslNFycot3YZG0N87PeQpctbx0Hpo99R7n/fPNybbML3dJYATABgZ8gvzgSoIs9fI+s/umoa5tda1HuFOSBI56ALo3sVCtmyJ3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736076595; c=relaxed/simple; bh=jQc97fg4KojjI1la88iIuV/bPNMe7W7Ss02Ow8E+fjw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kpV7kIEolO7yvVrMia1ow7Ixz5GiZ57QbjF5Y8FRv46dBq8yXBOJeGdtoS8ugsCSQsUgoYozUZ20KtRC80uyZplzn5wHZxIS8PM7S+dlwiWtix5+RlAJ8+oH/6wc3JlotXDE2YzGUiJPRpV4/7xfeh/IM6rOjE1ZtQYEzym6KKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=K4FE0h0C; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="K4FE0h0C" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jQc97fg4KojjI1la88iIuV/bPNMe7W7Ss02Ow8E+fjw=; b=K4FE0h0C/K++e0AjhiWXif8i8D n45dASdKMtxeWVP1iu/nhtVVvIMj3QaxC2cse6qFRSJFEaOaBMonimfLSLA0octEb9zui4iuPP9Kz 3ecLW/bcS98vYfI+OH0VEuRMfhbrAnmr5iQS3hnT7gl7Y9ug8CSfo4LOE9p0f7yM/mewksCFBmIXv DAJM9Q+vGeOJd53zs6ACpBnijBYU41dEeDFDvF5yNIArUWWHFuMuHkoxXitPB80ib1bOj6ZXXe7wc Aj7gy90UdHkgbYHlshQyEGLcxU7+xWu+qwCGzAqevMaJ4xzqTpUEvxxxmMAcODLErloUpkoqZVtEU SrYeTPQw==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1tUOpI-0000000FckR-3OjF; Sun, 05 Jan 2025 11:29:48 +0000 Date: Sun, 5 Jan 2025 11:29:48 +0000 From: Al Viro To: Eric Dumazet Cc: Matthieu Baerts , davem@davemloft.net, geliang@kernel.org, horms@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, martineau@kernel.org, mptcp@lists.linux.dev, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com, syzbot Subject: Re: [syzbot] [mptcp?] general protection fault in proc_scheduler Message-ID: <20250105112948.GI1977892@ZenIV> References: <67769ecb.050a0220.3a8527.003f.GAE@google.com> <20250104190010.GF1977892@ZenIV> <89c2208c-fe23-43eb-89ef-876e55731a50@kernel.org> <20250104202126.GH1977892@ZenIV> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro On Sun, Jan 05, 2025 at 09:32:36AM +0100, Eric Dumazet wrote: > According to grep, we have many other places directly reading > current->nsproxy->net_ns > For instance in net/sctp/sysctl.c > Should we change them all ? Depends - do you want their contents match the netns of opener (as, AFAICS, for ipv4 sysctls) or that of the reader?