From: Greg KH <gregkh@linuxfoundation.org>
To: Foster Snowhill <forst@pen.gy>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Georgi Valkov <gvalkov@gmail.com>,
Simon Horman <horms@kernel.org>, Oliver Neukum <oneukum@suse.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net v4 6/7] usbnet: ipheth: fix DPE OoB read
Date: Sun, 5 Jan 2025 08:46:13 +0100 [thread overview]
Message-ID: <2025010558-lining-paralysis-e618@gregkh> (raw)
In-Reply-To: <20250105010121.12546-7-forst@pen.gy>
On Sun, Jan 05, 2025 at 02:01:20AM +0100, Foster Snowhill wrote:
> Fix an out-of-bounds DPE read, limit the number of processed DPEs to
> the amount that fits into the fixed-size NDP16 header.
>
> Fixes: a2d274c62e44 ("usbnet: ipheth: add CDC NCM support")
> Signed-off-by: Foster Snowhill <forst@pen.gy>
> ---
> v4:
> Split from "usbnet: ipheth: refactor NCM datagram loop, fix DPE OoB
> read" in v3. This commit is responsible for addressing the potential
> OoB read.
> v3: https://lore.kernel.org/netdev/20241123235432.821220-5-forst@pen.gy/
> Split out from a monolithic patch in v2 as an atomic change.
> v2: https://lore.kernel.org/netdev/20240912211817.1707844-1-forst@pen.gy/
> No code changes. Update commit message to further clarify that
> `ipheth` is not and does not aim to be a complete or spec-compliant
> CDC NCM implementation.
> v1: https://lore.kernel.org/netdev/20240907230108.978355-1-forst@pen.gy/
> ---
> drivers/net/usb/ipheth.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You have marked a patch with a "Fixes:" tag for a commit that is in an
older released kernel, yet you do not have a cc: stable line in the
signed-off-by area at all, which means that the patch will not be
applied to any older kernel releases. To properly fix this, please
follow the documented rules in the
Documentation/process/stable-kernel-rules.rst file for how to resolve
this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2025-01-05 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 1:01 [PATCH net v4 0/7] usbnet: ipheth: prevent OoB reads of NDP16 Foster Snowhill
2025-01-05 1:01 ` [PATCH net v4 1/7] usbnet: ipheth: break up NCM header size computation Foster Snowhill
2025-01-05 1:01 ` [PATCH net v4 2/7] usbnet: ipheth: fix possible overflow in DPE length check Foster Snowhill
2025-01-05 1:01 ` [PATCH net v4 3/7] usbnet: ipheth: check that DPE points past NCM header Foster Snowhill
2025-01-05 1:01 ` [PATCH net v4 4/7] usbnet: ipheth: use static NDP16 location in URB Foster Snowhill
2025-01-05 7:46 ` Greg KH
2025-01-05 1:01 ` [PATCH net v4 5/7] usbnet: ipheth: refactor NCM datagram loop Foster Snowhill
2025-01-05 1:01 ` [PATCH net v4 6/7] usbnet: ipheth: fix DPE OoB read Foster Snowhill
2025-01-05 7:46 ` Greg KH [this message]
2025-01-05 1:01 ` [PATCH net v4 7/7] usbnet: ipheth: document scope of NCM implementation Foster Snowhill
2025-01-08 1:31 ` [PATCH net v4 0/7] usbnet: ipheth: prevent OoB reads of NDP16 Jakub Kicinski
2025-01-13 1:48 ` Foster Snowhill
2025-01-13 20:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025010558-lining-paralysis-e618@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=forst@pen.gy \
--cc=gvalkov@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).