From: Jakub Kicinski <kuba@kernel.org>
To: Su Hui <suhui@nfschina.com>
Cc: alexanderduyck@fb.com, kernel-team@meta.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jdelvare@suse.com, linux@roeck-us.net,
michal.swiatkowski@linux.intel.com, mohsin.bashr@gmail.com,
sanmanpradhan@meta.com, vadim.fedorenko@linux.dev,
kalesh-anakkur.purayil@broadcom.com, horms@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3] eth: fbnic: Revert "eth: fbnic: Add hardware monitoring support via HWMON interface"
Date: Mon, 6 Jan 2025 07:31:44 -0800 [thread overview]
Message-ID: <20250106073144.25d6b9fb@kernel.org> (raw)
In-Reply-To: <20250106023647.47756-1-suhui@nfschina.com>
On Mon, 6 Jan 2025 10:36:48 +0800 Su Hui wrote:
> There is a garbage value problem in fbnic_mac_get_sensor_asic(). 'fw_cmpl'
> is uninitialized which makes 'sensor' and '*val' to be stored garbage
> value. Revert commit d85ebade02e8 ("eth: fbnic: Add hardware monitoring
> support via HWMON interface") to avoid this problem.
>
> Fixes: d85ebade02e8 ("eth: fbnic: Add hardware monitoring support via HWMON interface")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Suggested-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Thanks!
next prev parent reply other threads:[~2025-01-06 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 2:36 [PATCH v3] eth: fbnic: Revert "eth: fbnic: Add hardware monitoring support via HWMON interface" Su Hui
2025-01-06 15:31 ` Jakub Kicinski [this message]
2025-01-07 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106073144.25d6b9fb@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdelvare@suse.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanmanpradhan@meta.com \
--cc=suhui@nfschina.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).