From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>,
Yevgeny Kliteynik <kliteyn@nvidia.com>,
Vlad Dogaru <vdogaru@nvidia.com>,
Erez Shitrit <erezsh@nvidia.com>
Subject: Re: [PATCH net-next 03/15] net/mlx5: HWS, denote how refcounts are protected
Date: Mon, 6 Jan 2025 16:36:24 -0800 [thread overview]
Message-ID: <20250106163624.7cebcbeb@kernel.org> (raw)
In-Reply-To: <20250102181415.1477316-4-tariqt@nvidia.com>
On Thu, 2 Jan 2025 20:14:02 +0200 Tariq Toukan wrote:
> From: Yevgeny Kliteynik <kliteyn@nvidia.com>
>
> Some HWS structs have refcounts that are just u32.
> Comment how they are protected and add '__must_hold()'
> annotation where applicable.
Out of curiosity -- do you have tooling which uses those annotations?
Can smatch use it? IIUC the sparse matching on the lock state is pretty
much disabled these days.
next prev parent reply other threads:[~2025-01-07 0:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 18:13 [PATCH net-next 00/15] mlx5 Hardware Steering part 2 Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 01/15] net/mlx5: HWS, remove the use of duplicated structs Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 02/15] net/mlx5: HWS, remove implementation of unused FW commands Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 03/15] net/mlx5: HWS, denote how refcounts are protected Tariq Toukan
2025-01-07 0:36 ` Jakub Kicinski [this message]
2025-01-07 1:03 ` Yevgeny Kliteynik
2025-01-02 18:14 ` [PATCH net-next 04/15] net/mlx5: HWS, simplify allocations as we support only FDB Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 05/15] net/mlx5: HWS, add error message on failure to move rules Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 06/15] net/mlx5: HWS, change error flow on matcher disconnect Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 07/15] net/mlx5: HWS, remove wrong deletion of the miss table list Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 08/15] net/mlx5: HWS, reduce memory consumption of a matcher struct Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 09/15] net/mlx5: HWS, num_of_rules counter on matcher should be atomic Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 10/15] net/mlx5: HWS, separate SQ that HWS uses from the usual traffic SQs Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 11/15] net/mlx5: HWS, fix definer's HWS_SET32 macro for negative offset Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 12/15] net/mlx5: HWS, handle returned error value in pool alloc Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 13/15] net/mlx5: HWS, use the right size when writing arg data Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 14/15] net/mlx5: HWS, support flow sampler destination Tariq Toukan
2025-01-02 18:14 ` [PATCH net-next 15/15] net/mlx5: HWS, set timeout on polling for completion Tariq Toukan
2025-01-07 0:50 ` [PATCH net-next 00/15] mlx5 Hardware Steering part 2 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106163624.7cebcbeb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=erezsh@nvidia.com \
--cc=gal@nvidia.com \
--cc=kliteyn@nvidia.com \
--cc=leonro@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vdogaru@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).