From: Jakub Kicinski <kuba@kernel.org>
To: John Ousterhout <ouster@cs.stanford.edu>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org
Subject: Re: [PATCH net-next v5 06/12] net: homa: create homa_peer.h and homa_peer.c
Date: Tue, 7 Jan 2025 06:15:10 -0800 [thread overview]
Message-ID: <20250107061510.0adcf6c6@kernel.org> (raw)
In-Reply-To: <20250106181219.1075-7-ouster@cs.stanford.edu>
On Mon, 6 Jan 2025 10:12:12 -0800 John Ousterhout wrote:
> +void homa_dst_refresh(struct homa_peertab *peertab, struct homa_peer *peer,
> + struct homa_sock *hsk)
> +{
> + struct dst_entry *dst;
> +
> + spin_lock_bh(&peertab->write_lock);
> + dst = homa_peer_get_dst(peer, &hsk->inet);
> + if (!IS_ERR(dst)) {
> + struct homa_dead_dst *dead = (struct homa_dead_dst *)
> + kmalloc(sizeof(*dead), GFP_KERNEL);
coccicheck says:
net/homa/homa_peer.c:227:32-52: WARNING: casting value returned by memory allocation function to (struct homa_dead_dst *) is useless.
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-07 14:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 18:12 [PATCH net-next v5 00/12] Begin upstreaming Homa transport protocol John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 01/12] net: homa: define user-visible API for Homa John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 02/12] net: homa: create homa_wire.h John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 03/12] net: homa: create shared Homa header files John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 04/12] net: homa: create homa_pool.h and homa_pool.c John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 05/12] net: homa: create homa_rpc.h and homa_rpc.c John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 06/12] net: homa: create homa_peer.h and homa_peer.c John Ousterhout
2025-01-07 14:15 ` Jakub Kicinski [this message]
2025-01-07 20:53 ` John Ousterhout
2025-01-07 21:02 ` Eric Dumazet
2025-01-07 21:24 ` Jakub Kicinski
2025-01-07 21:58 ` John Ousterhout
2025-01-08 0:02 ` Jakub Kicinski
2025-01-07 21:51 ` John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 07/12] net: homa: create homa_sock.h and homa_sock.c John Ousterhout
2025-01-08 14:56 ` D. Wythe
2025-01-09 18:35 ` John Ousterhout
2025-01-10 9:25 ` D. Wythe
2025-01-11 0:19 ` John Ousterhout
2025-01-11 8:30 ` Jason Xing
2025-01-13 17:11 ` John Ousterhout
2025-01-14 0:20 ` Jason Xing
2025-01-06 18:12 ` [PATCH net-next v5 08/12] net: homa: create homa_incoming.c John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 09/12] net: homa: create homa_outgoing.c John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 10/12] net: homa: create homa_timer.c John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 11/12] net: homa: create homa_plumbing.c homa_utils.c John Ousterhout
2025-01-06 18:12 ` [PATCH net-next v5 12/12] net: homa: create Makefile and Kconfig John Ousterhout
2025-01-13 17:27 ` [PATCH net-next v5 00/12] Begin upstreaming Homa transport protocol John Ousterhout
2025-01-13 20:06 ` Andrew Lunn
2025-01-13 20:47 ` John Ousterhout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107061510.0adcf6c6@kernel.org \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ouster@cs.stanford.edu \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).