netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Ariel Otilibili-Anieli <Ariel.Otilibili-Anieli@eurecom.fr>
Cc: "Daniel Golle" <daniel@makrotopia.org>,
	"Shiji Yang" <yangshiji66@outlook.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	"Kalle Valo" <kvalo@kernel.org>,
	"Tomislav Požega" <pozega.tomislav@gmail.com>,
	Linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rt2x00: Remove unusued value
Date: Tue, 7 Jan 2025 11:23:35 +0100	[thread overview]
Message-ID: <20250107102335.GA2355@wp.pl> (raw)
In-Reply-To: <2f7a84-677b8500-5061-4ac1e700@152950135>

Hi Ariel,

On Mon, Jan 06, 2025 at 08:23:34AM +0100, Ariel Otilibili-Anieli wrote:
> Hi Daniel, hi Shiji, hi Stanislaw,
> 
> On Sunday, January 05, 2025 22:21 CET, Daniel Golle <daniel@makrotopia.org> wrote:
> 
> > H again,
> > 
> > 
> > On Sat, Jan 04, 2025 at 01:51:25PM +0100, Ariel Otilibili-Anieli wrote:
> > > Great, then; thanks for having acked the patch as such.
> > 
> > I just noticed that Shiji Yang had posted a series of patches for
> > OpenWrt which also addresses the same issue, however, instead of
> > removing the augmented assignment, it fixes it to the supposedly
> > originally intended way.
> > 
> > See
> > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/mac80211/patches/rt2x00/621-04-rt2x00-fix-register-operation-on-RXIQ-calibration.patch;h=aa6f9c437c6447831490588b2cead6919accda58;hb=5d583901657bdfbbf9fad77d9247872427aa5c99
> > 
> > I suppose this was tested together with the other changes of the same
> > series, so we may want to pick that instead.
> 
> Thanks for having put some time into the research, Daniel; I looked into the openwrt archives for 2024, none of Shiji’s messages mentions that patch.
> 
> Though, if you three agree, I will push a new series, modelled on that patch, and you as Suggested-by.

Please post that change. But to not mix it with
patches against other drivers in the same series.
(multiple rt2x00 patches in one patchset are ok).

And please use "wifi: rt2x00:" as subject prefix.

Thanks
Stanislaw

  reply	other threads:[~2025-01-07 10:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-21 12:39 [PATCH 0/2] rt2x00,net/phy,neterion: Remove dead values Ariel Otilibili
2024-12-21 12:39 ` [PATCH 1/2] rt2x00: Remove unusued value Ariel Otilibili
2025-01-03  8:55   ` Stanislaw Gruszka
2025-01-03 11:40     ` Daniel Golle
2025-01-03 13:10       ` Stanislaw Gruszka
2025-01-03 13:39         ` Ariel Otilibili-Anieli
2025-01-04 10:37           ` Stanislaw Gruszka
2025-01-04 12:51             ` Ariel Otilibili-Anieli
2025-01-05 21:21               ` Daniel Golle
2025-01-06  7:23                 ` Ariel Otilibili-Anieli
2025-01-07 10:23                   ` Stanislaw Gruszka [this message]
2025-01-07 11:01                   ` Jonas Gorski
2025-01-10 13:12   ` [1/2] wifi: rt2x00: Remove unused rfval values Kalle Valo
2024-12-21 12:39 ` [PATCH 2/2] net/phy,neterion: Remove dead values Ariel Otilibili
2024-12-21 15:06   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107102335.GA2355@wp.pl \
    --to=stf_xl@wp.pl \
    --cc=Ariel.Otilibili-Anieli@eurecom.fr \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pozega.tomislav@gmail.com \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).