From: Jakub Kicinski <kuba@kernel.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
ronak.doshi@broadcom.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] vmxnet3: Adjust maximum Rx ring buffer size
Date: Tue, 7 Jan 2025 15:46:47 -0800 [thread overview]
Message-ID: <20250107154647.4bcbae3c@kernel.org> (raw)
In-Reply-To: <2f127a6d-7fa2-5e99-093f-40ab81ece5b1@atomlin.com>
On Tue, 7 Jan 2025 22:55:38 +0000 (GMT) Aaron Tomlin wrote:
> On Tue, 7 Jan 2025, Jakub Kicinski wrote:
> > True, although TBH I don't fully understand why this flag exists
> > in the first place. Is it just supposed to be catching programming
> > errors, or is it due to potential DoS implications of users triggering
> > large allocations?
>
> Jakub,
>
> I suspect that introducing __GFP_NOWARN would mask the issue, no?
> I think the warning was useful. Otherwise it would be rather difficult to
> establish precisely why the Rx Data ring was disable. In this particular
> case, if I understand correctly, the intended size of the Rx Data ring was
> simply too large due to the size of the maximum supported Rx Data buffer.
This is a bit of a weird driver. But we should distinguish the default
ring size, which yes, should not be too large, and max ring size which
can be large but user setting a large size risks the fact the
allocations will fail and device will not open.
This driver seems to read the default size from the hypervisor, is that
the value that is too large in your case? Maybe we should min() it with
something reasonable? The max allowed to be set via ethtool can remain
high IMO
next prev parent reply other threads:[~2025-01-07 23:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 21:30 [RFC PATCH 0/1] vmxnet3: Adjust maximum Rx ring buffer size Aaron Tomlin
2025-01-05 21:30 ` [RFC PATCH 1/1] " Aaron Tomlin
2025-01-06 23:47 ` [RFC PATCH 0/1] " Jakub Kicinski
2025-01-06 23:51 ` Florian Fainelli
2025-01-07 0:57 ` Jakub Kicinski
2025-01-07 22:55 ` Aaron Tomlin
2025-01-07 23:46 ` Jakub Kicinski [this message]
[not found] ` <CAP1Q3XQ_Fubke4=SYrFkaiJj0RHB99ehdMedMVDTFtRS6R_RCw@mail.gmail.com>
2025-01-08 17:24 ` Ronak Doshi
2025-01-08 21:05 ` Aaron Tomlin
2025-01-15 20:55 ` Aaron Tomlin
2025-01-08 16:53 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107154647.4bcbae3c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=atomlin@atomlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronak.doshi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).