From: kernel test robot <lkp@intel.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jose Abreu <joabreu@synopsys.com>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v2 12/17] net: stmmac: move priv->eee_active into stmmac_eee_init()
Date: Tue, 7 Jan 2025 15:28:23 +0800 [thread overview]
Message-ID: <202501071547.L5CjLObQ-lkp@intel.com> (raw)
In-Reply-To: <E1tUmAz-007VXn-0o@rmk-PC.armlinux.org.uk>
Hi Russell,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-stmmac-move-tx_lpi_timer-tracking-to-phylib/20250107-002808
base: net-next/main
patch link: https://lore.kernel.org/r/E1tUmAz-007VXn-0o%40rmk-PC.armlinux.org.uk
patch subject: [PATCH net-next v2 12/17] net: stmmac: move priv->eee_active into stmmac_eee_init()
config: i386-buildonly-randconfig-005-20250107 (https://download.01.org/0day-ci/archive/20250107/202501071547.L5CjLObQ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250107/202501071547.L5CjLObQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501071547.L5CjLObQ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:468: warning: Function parameter or struct member 'active' not described in 'stmmac_eee_init'
vim +468 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 458
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 459 /**
732fdf0e5253e9 Giuseppe CAVALLARO 2014-11-18 460 * stmmac_eee_init - init EEE
32ceabcad3c8ab Giuseppe CAVALLARO 2013-04-08 461 * @priv: driver private structure
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 462 * Description:
732fdf0e5253e9 Giuseppe CAVALLARO 2014-11-18 463 * if the GMAC supports the EEE (from the HW cap reg) and the phy device
732fdf0e5253e9 Giuseppe CAVALLARO 2014-11-18 464 * can also manage EEE, this function enable the LPI state and start related
732fdf0e5253e9 Giuseppe CAVALLARO 2014-11-18 465 * timer.
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 466 */
5ad24fd233fa83 Russell King (Oracle 2025-01-06 467) static void stmmac_eee_init(struct stmmac_priv *priv, bool active)
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 @468 {
5ad24fd233fa83 Russell King (Oracle 2025-01-06 469) priv->eee_active = active;
5ad24fd233fa83 Russell King (Oracle 2025-01-06 470)
74371272f97fd1 Jose Abreu 2019-06-11 471 /* Check if MAC core supports the EEE feature. */
418ee895284762 Russell King (Oracle 2025-01-06 472) if (!priv->dma_cap.eee) {
418ee895284762 Russell King (Oracle 2025-01-06 473) priv->eee_enabled = false;
418ee895284762 Russell King (Oracle 2025-01-06 474) return;
418ee895284762 Russell King (Oracle 2025-01-06 475) }
83bf79b6bb64e6 Giuseppe CAVALLARO 2014-03-10 476
29555fa3de8656 Thierry Reding 2018-05-24 477 mutex_lock(&priv->lock);
74371272f97fd1 Jose Abreu 2019-06-11 478
74371272f97fd1 Jose Abreu 2019-06-11 479 /* Check if it needs to be deactivated */
177d935a13703e Jon Hunter 2019-06-26 480 if (!priv->eee_active) {
177d935a13703e Jon Hunter 2019-06-26 481 if (priv->eee_enabled) {
38ddc59d65b6d9 LABBE Corentin 2016-11-16 482 netdev_dbg(priv->dev, "disable EEE\n");
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 483 stmmac_lpi_entry_timer_config(priv, 0);
83bf79b6bb64e6 Giuseppe CAVALLARO 2014-03-10 484 del_timer_sync(&priv->eee_ctrl_timer);
26dbf37afd5d4b Russell King (Oracle 2025-01-06 485) stmmac_set_eee_timer(priv, priv->hw, 0,
26dbf37afd5d4b Russell King (Oracle 2025-01-06 486) STMMAC_DEFAULT_TWT_LS);
d4aeaed80b0ebb Wong Vee Khee 2021-10-05 487 if (priv->hw->xpcs)
d4aeaed80b0ebb Wong Vee Khee 2021-10-05 488 xpcs_config_eee(priv->hw->xpcs,
d4aeaed80b0ebb Wong Vee Khee 2021-10-05 489 priv->plat->mult_fact_100ns,
d4aeaed80b0ebb Wong Vee Khee 2021-10-05 490 false);
177d935a13703e Jon Hunter 2019-06-26 491 }
418ee895284762 Russell King (Oracle 2025-01-06 492) priv->eee_enabled = false;
0867bb9768deda Jon Hunter 2019-06-26 493 mutex_unlock(&priv->lock);
418ee895284762 Russell King (Oracle 2025-01-06 494) return;
83bf79b6bb64e6 Giuseppe CAVALLARO 2014-03-10 495 }
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 496
74371272f97fd1 Jose Abreu 2019-06-11 497 if (priv->eee_active && !priv->eee_enabled) {
74371272f97fd1 Jose Abreu 2019-06-11 498 timer_setup(&priv->eee_ctrl_timer, stmmac_eee_ctrl_timer, 0);
74371272f97fd1 Jose Abreu 2019-06-11 499 stmmac_set_eee_timer(priv, priv->hw, STMMAC_DEFAULT_LIT_LS,
26dbf37afd5d4b Russell King (Oracle 2025-01-06 500) STMMAC_DEFAULT_TWT_LS);
656ed8b015f19b Wong Vee Khee 2021-09-30 501 if (priv->hw->xpcs)
656ed8b015f19b Wong Vee Khee 2021-09-30 502 xpcs_config_eee(priv->hw->xpcs,
656ed8b015f19b Wong Vee Khee 2021-09-30 503 priv->plat->mult_fact_100ns,
656ed8b015f19b Wong Vee Khee 2021-09-30 504 true);
71965352eedd0c Giuseppe CAVALLARO 2014-08-28 505 }
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 506
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 507 if (priv->plat->has_gmac4 && priv->tx_lpi_timer <= STMMAC_ET_MAX) {
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 508 del_timer_sync(&priv->eee_ctrl_timer);
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 509 priv->tx_path_in_lpi_mode = false;
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 510 stmmac_lpi_entry_timer_config(priv, 1);
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 511 } else {
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 512 stmmac_lpi_entry_timer_config(priv, 0);
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 513 mod_timer(&priv->eee_ctrl_timer,
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 514 STMMAC_LPI_T(priv->tx_lpi_timer));
be1c7eae8c7dfc Vineetha G. Jaya Kumaran 2020-10-28 515 }
388e201d41fa1e Vineetha G. Jaya Kumaran 2020-10-01 516
418ee895284762 Russell King (Oracle 2025-01-06 517) priv->eee_enabled = true;
418ee895284762 Russell King (Oracle 2025-01-06 518)
29555fa3de8656 Thierry Reding 2018-05-24 519 mutex_unlock(&priv->lock);
38ddc59d65b6d9 LABBE Corentin 2016-11-16 520 netdev_dbg(priv->dev, "Energy-Efficient Ethernet initialized\n");
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 521 }
d765955d2ae0b8 Giuseppe CAVALLARO 2012-06-27 522
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-01-07 7:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 12:24 [PATCH net-next 00/17] net: stmmac: clean up and fix EEE implementation Russell King (Oracle)
2025-01-06 12:24 ` [PATCH net-next v2 01/17] net: phy: add configuration of rx clock stop mode Russell King (Oracle)
2025-01-06 12:24 ` [PATCH net-next v2 02/17] net: stmmac: move tx_lpi_timer tracking to phylib Russell King (Oracle)
2025-01-06 16:44 ` Andrew Lunn
2025-01-06 12:24 ` [PATCH net-next v2 03/17] net: stmmac: use correct type for tx_lpi_timer Russell King (Oracle)
2025-01-06 16:45 ` Andrew Lunn
2025-01-07 16:34 ` Russell King (Oracle)
2025-01-07 11:28 ` Simon Horman
2025-01-07 11:57 ` Russell King (Oracle)
2025-01-07 14:41 ` Simon Horman
2025-01-07 15:26 ` Russell King (Oracle)
2025-01-08 9:42 ` Simon Horman
2025-01-06 12:25 ` [PATCH net-next v2 04/17] net: stmmac: make EEE depend on phy->enable_tx_lpi Russell King (Oracle)
2025-01-06 16:48 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 05/17] net: stmmac: remove redundant code from ethtool EEE ops Russell King (Oracle)
2025-01-06 16:49 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 06/17] net: stmmac: clean up stmmac_disable_eee_mode() Russell King (Oracle)
2025-01-06 16:50 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 07/17] net: stmmac: remove priv->tx_lpi_enabled Russell King (Oracle)
2025-01-06 16:50 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 08/17] net: stmmac: report EEE error statistics if EEE is supported Russell King (Oracle)
2025-01-06 16:51 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 09/17] net: stmmac: convert to use phy_eee_rx_clock_stop() Russell King (Oracle)
2025-01-06 17:02 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 10/17] net: stmmac: remove priv->eee_tw_timer Russell King (Oracle)
2025-01-06 17:02 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 11/17] net: stmmac: move priv->eee_enabled into stmmac_eee_init() Russell King (Oracle)
2025-01-06 17:04 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 12/17] net: stmmac: move priv->eee_active " Russell King (Oracle)
2025-01-06 17:05 ` Andrew Lunn
2025-01-07 7:28 ` kernel test robot [this message]
2025-01-06 12:25 ` [PATCH net-next v2 13/17] net: stmmac: use boolean for eee_enabled and eee_active Russell King (Oracle)
2025-01-06 17:05 ` Andrew Lunn
2025-01-06 12:25 ` [PATCH net-next v2 14/17] net: stmmac: move setup of eee_ctrl_timer to stmmac_dvr_probe() Russell King (Oracle)
2025-01-06 17:05 ` Andrew Lunn
2025-01-06 12:26 ` [PATCH net-next v2 15/17] net: stmmac: remove unnecessary EEE handling in stmmac_release() Russell King (Oracle)
2025-01-06 17:06 ` Andrew Lunn
2025-01-06 12:26 ` [PATCH net-next v2 16/17] net: stmmac: split hardware LPI timer control Russell King (Oracle)
2025-01-06 17:07 ` Andrew Lunn
2025-01-06 12:26 ` [PATCH net-next v2 17/17] net: stmmac: remove stmmac_lpi_entry_timer_config() Russell King (Oracle)
2025-01-06 17:08 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501071547.L5CjLObQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).