netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ipvlan: Support bonding events
@ 2025-01-05  0:36 Etienne Champetier
  2025-01-05  8:15 ` Eric Dumazet
  2025-01-08  1:04 ` [PATCH] " Jakub Kicinski
  0 siblings, 2 replies; 4+ messages in thread
From: Etienne Champetier @ 2025-01-05  0:36 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, netdev
  Cc: Etienne Champetier

This allows ipvlan to function properly on top of
bonds using active-backup mode.
This was implemented for macvlan in 2014 in commit
4c9912556867 ("macvlan: Support bonding events").

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
---
 drivers/net/ipvlan/ipvlan_main.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index ee2c3cf4df36..da3a97a65507 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -799,6 +799,12 @@ static int ipvlan_device_event(struct notifier_block *unused,
 	case NETDEV_PRE_TYPE_CHANGE:
 		/* Forbid underlying device to change its type. */
 		return NOTIFY_BAD;
+
+	case NETDEV_NOTIFY_PEERS:
+	case NETDEV_BONDING_FAILOVER:
+	case NETDEV_RESEND_IGMP:
+		list_for_each_entry(ipvlan, &port->ipvlans, pnode)
+			call_netdevice_notifiers(event, ipvlan->dev);
 	}
 	return NOTIFY_DONE;
 }
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ipvlan: Support bonding events
  2025-01-05  0:36 [PATCH] ipvlan: Support bonding events Etienne Champetier
@ 2025-01-05  8:15 ` Eric Dumazet
  2025-01-05 20:10   ` [PATCH net-next] " Etienne Champetier
  2025-01-08  1:04 ` [PATCH] " Jakub Kicinski
  1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2025-01-05  8:15 UTC (permalink / raw)
  To: Etienne Champetier
  Cc: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni, netdev

On Sun, Jan 5, 2025 at 1:43 AM Etienne Champetier
<champetier.etienne@gmail.com> wrote:
>
> This allows ipvlan to function properly on top of
> bonds using active-backup mode.
> This was implemented for macvlan in 2014 in commit
> 4c9912556867 ("macvlan: Support bonding events").
>
> Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

Which tree are you targeting ?

Please look at Documentation/process/maintainer-netdev.rst  for reference.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] ipvlan: Support bonding events
  2025-01-05  8:15 ` Eric Dumazet
@ 2025-01-05 20:10   ` Etienne Champetier
  0 siblings, 0 replies; 4+ messages in thread
From: Etienne Champetier @ 2025-01-05 20:10 UTC (permalink / raw)
  To: Eric Dumazet
  Cc: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni, netdev


Le 05/01/2025 à 03:15, Eric Dumazet a écrit :
> On Sun, Jan 5, 2025 at 1:43 AM Etienne Champetier
> <champetier.etienne@gmail.com> wrote:
>> This allows ipvlan to function properly on top of
>> bonds using active-backup mode.
>> This was implemented for macvlan in 2014 in commit
>> 4c9912556867 ("macvlan: Support bonding events").
>>
>> Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
> Which tree are you targeting ?
>
> Please look at Documentation/process/maintainer-netdev.rst  for reference.

Sorry about that, that would be net-next


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ipvlan: Support bonding events
  2025-01-05  0:36 [PATCH] ipvlan: Support bonding events Etienne Champetier
  2025-01-05  8:15 ` Eric Dumazet
@ 2025-01-08  1:04 ` Jakub Kicinski
  1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2025-01-08  1:04 UTC (permalink / raw)
  To: Etienne Champetier
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni, netdev

On Sat,  4 Jan 2025 19:36:19 -0500 Etienne Champetier wrote:
> This allows ipvlan to function properly on top of
> bonds using active-backup mode.
> This was implemented for macvlan in 2014 in commit
> 4c9912556867 ("macvlan: Support bonding events").

Would you be able to parametrize:

tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh

to run over macvlan and ipvlan? It would be great to have some
test coverage for this setup. Currently:

$ git grep ipvlan -- tools/testing/selftests/drivers/net/bonding/
$
-- 
pw-bot: cr

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-01-08  1:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-05  0:36 [PATCH] ipvlan: Support bonding events Etienne Champetier
2025-01-05  8:15 ` Eric Dumazet
2025-01-05 20:10   ` [PATCH net-next] " Etienne Champetier
2025-01-08  1:04 ` [PATCH] " Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).