From: Jakub Kicinski <kuba@kernel.org>
To: Li RongQing <lirongqing@baidu.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][Resend][net-next] net: ethtool: Use hwprov under rcu_read_lock
Date: Tue, 7 Jan 2025 17:40:45 -0800 [thread overview]
Message-ID: <20250107174045.3763ffd2@kernel.org> (raw)
In-Reply-To: <20250107173943.223f62f9@kernel.org>
On Tue, 7 Jan 2025 17:39:43 -0800 Jakub Kicinski wrote:
> On Sun, 5 Jan 2025 16:40:52 +0800 Li RongQing wrote:
> > hwprov should be protected by rcu_read_lock to prevent possible UAF
> >
> > Fixes: 4c61d809cf60 ("net: ethtool: Fix suspicious rcu_dereference usage")
> > Signed-off-by: Li RongQing <lirongqing@baidu.com>
>
> In the future please make sure you CC the appropriate authors and
> maintainers. Always use get_maintainer.pl on the generated patch file.
Actually, the code could be improved, too.
Don't declare ret, move the declaration of int err instead.
--
pw-bot: cr
prev parent reply other threads:[~2025-01-08 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 8:40 [PATCH][Resend][net-next] net: ethtool: Use hwprov under rcu_read_lock Li RongQing
2025-01-08 1:39 ` Jakub Kicinski
2025-01-08 1:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107174045.3763ffd2@kernel.org \
--to=kuba@kernel.org \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).