netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-doc@vger.kernel.org, Kyle Swenson <kyle.swenson@est.tech>,
	Dent Project <dentproject@linuxfoundation.org>,
	kernel@pengutronix.de,
	Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next 11/14] net: pse-pd: Add support for PSE device index
Date: Wed, 8 Jan 2025 09:42:01 -0800	[thread overview]
Message-ID: <20250108094201.63463180@kernel.org> (raw)
In-Reply-To: <Z34RXjqUKBdDqAGF@pengutronix.de>

On Wed, 8 Jan 2025 06:47:10 +0100 Oleksij Rempel wrote:
> On Tue, Jan 07, 2025 at 05:18:34PM -0800, Jakub Kicinski wrote:
> > On Sat, 04 Jan 2025 23:27:36 +0100 Kory Maincent wrote:  
> > > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > > 
> > > Add support for a PSE device index to report the PSE controller index to
> > > the user through ethtool. This will be useful for future support of power
> > > domains and port priority management.  
> > 
> > Can you say more? How do the PSE controllers relate to netdevs?
> > ethtool is primarily driven by netdev / ifindex.
> > If you're starting to build your own object hierarchy you may be
> > better off with a separate genl family.  
>             
> I hope this schema may help to explain the topology:
> 
> 	                              +--- netdev / ifindex 0
> 	    +--- PSE power domain 0 --+--- netdev / ifindex 1
>             |                         +--- netdev / ifindex 2
> PSE ctrl 0 -+
>             |                         +--- netdev / ifindex 3
>             +--- PSE power domain 1 --+--- netdev / ifindex 4
> 	                              +--- netdev / ifindex 5
> 
> 	                              +--- netdev / ifindex 6
> 	    +--- PSE power domain 2 --+--- netdev / ifindex 7
>             |                         +--- netdev / ifindex 8
> PSE ctrl 1 -+
>             |                         +--- netdev / ifindex 9
>             +--- PSE power domain 3 --+--- netdev / ifindex 10
> 	                              +--- netdev / ifindex 11
> 
> PSE device index is needed to find actually PSE controller related to
> specific netdev / ifindex.

Makes sense. So how does it end up looking in terms of APIs 
and attributes? Will we need much more than power limits at
the domain and ctrl level?

  reply	other threads:[~2025-01-08 17:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-04 22:27 [PATCH net-next 00/14] Arrange PSE core and update TPS23881 driver Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 01/14] net: pse-pd: Remove unused pse_ethtool_get_pw_limit function declaration Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 02/14] net: pse-pd: Avoid setting max_uA in regulator constraints Kory Maincent
2025-01-08 11:14   ` Oleksij Rempel
2025-01-04 22:27 ` [PATCH net-next 03/14] net: pse-pd: Add power limit check Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 04/14] net: pse-pd: tps23881: Simplify function returns by removing redundant checks Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 05/14] net: pse-pd: tps23881: Use helpers to calculate bit offset for a channel Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 06/14] net: pse-pd: tps23881: Add missing configuration register after disable Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 07/14] net: pse-pd: Use power limit at driver side instead of current limit Kory Maincent
2025-01-08 11:13   ` Oleksij Rempel
2025-01-04 22:27 ` [PATCH net-next 08/14] net: pse-pd: Split ethtool_get_status into multiple callbacks Kory Maincent
2025-01-08  1:15   ` Jakub Kicinski
2025-01-08  9:27     ` Kory Maincent
2025-01-08 17:36       ` Jakub Kicinski
2025-01-09  9:01         ` Kory Maincent
2025-01-09  9:37         ` Paolo Abeni
2025-01-04 22:27 ` [PATCH net-next 09/14] net: pse-pd: Remove is_enabled callback from drivers Kory Maincent
2025-01-08 11:09   ` Oleksij Rempel
2025-01-04 22:27 ` [PATCH net-next 10/14] net: pse-pd: tps23881: Add support for power limit and measurement features Kory Maincent
2025-01-08 11:17   ` Oleksij Rempel
2025-01-04 22:27 ` [PATCH net-next 11/14] net: pse-pd: Add support for PSE device index Kory Maincent
2025-01-08  1:18   ` Jakub Kicinski
2025-01-08  5:47     ` Oleksij Rempel
2025-01-08 17:42       ` Jakub Kicinski [this message]
2025-01-08 18:17         ` Oleksij Rempel
2025-01-04 22:27 ` [PATCH net-next 12/14] net: ethtool: Add support for new PSE device index description Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 13/14] regulator: core: Resolve supply using of_node from regulator_config Kory Maincent
2025-01-04 22:27 ` [PATCH net-next 14/14] net: pse-pd: Fix missing PI of_node description Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250108094201.63463180@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dentproject@linuxfoundation.org \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kory.maincent@bootlin.com \
    --cc=kyle.swenson@est.tech \
    --cc=lgirdwood@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).