From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port()
Date: Wed, 8 Jan 2025 09:44:36 +0000 [thread overview]
Message-ID: <20250108094436.GF2772@kernel.org> (raw)
In-Reply-To: <20250107144701.503884-1-edumazet@google.com>
On Tue, Jan 07, 2025 at 02:47:01PM +0000, Eric Dumazet wrote:
> A synchronize_rcu() was added by mistake in commit
> c5a759117210 ("net/hsr: Use list_head (and rcu) instead
> of array for slave devices.")
>
> RCU does not mandate to observe a grace period after
> list_add_tail_rcu().
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-01-08 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 14:47 [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port() Eric Dumazet
2025-01-08 9:44 ` Simon Horman [this message]
2025-01-09 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108094436.GF2772@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).