* [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port()
@ 2025-01-07 14:47 Eric Dumazet
2025-01-08 9:44 ` Simon Horman
2025-01-09 12:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2025-01-07 14:47 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, Simon Horman, eric.dumazet, Eric Dumazet
A synchronize_rcu() was added by mistake in commit
c5a759117210 ("net/hsr: Use list_head (and rcu) instead
of array for slave devices.")
RCU does not mandate to observe a grace period after
list_add_tail_rcu().
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/hsr/hsr_slave.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/hsr/hsr_slave.c b/net/hsr/hsr_slave.c
index 006d6ef97e53f4077eb16f08077ee366d8cb4bbd..2a802a5de2acca1d87ad475b3c96d2464a1faad0 100644
--- a/net/hsr/hsr_slave.c
+++ b/net/hsr/hsr_slave.c
@@ -204,7 +204,6 @@ int hsr_add_port(struct hsr_priv *hsr, struct net_device *dev,
}
list_add_tail_rcu(&port->port_list, &hsr->ports);
- synchronize_rcu();
master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
netdev_update_features(master->dev);
--
2.47.1.613.gc27f4b7a9f-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port()
2025-01-07 14:47 [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port() Eric Dumazet
@ 2025-01-08 9:44 ` Simon Horman
2025-01-09 12:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-01-08 9:44 UTC (permalink / raw)
To: Eric Dumazet
Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, netdev,
eric.dumazet
On Tue, Jan 07, 2025 at 02:47:01PM +0000, Eric Dumazet wrote:
> A synchronize_rcu() was added by mistake in commit
> c5a759117210 ("net/hsr: Use list_head (and rcu) instead
> of array for slave devices.")
>
> RCU does not mandate to observe a grace period after
> list_add_tail_rcu().
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port()
2025-01-07 14:47 [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port() Eric Dumazet
2025-01-08 9:44 ` Simon Horman
@ 2025-01-09 12:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-01-09 12:30 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, kuba, pabeni, netdev, horms, eric.dumazet
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 7 Jan 2025 14:47:01 +0000 you wrote:
> A synchronize_rcu() was added by mistake in commit
> c5a759117210 ("net/hsr: Use list_head (and rcu) instead
> of array for slave devices.")
>
> RCU does not mandate to observe a grace period after
> list_add_tail_rcu().
>
> [...]
Here is the summary with links:
- [net-next] net: hsr: remove synchronize_rcu() from hsr_add_port()
https://git.kernel.org/netdev/net-next/c/a3b3d2dc3895
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-09 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-07 14:47 [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port() Eric Dumazet
2025-01-08 9:44 ` Simon Horman
2025-01-09 12:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).