From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4274719D8B7 for ; Wed, 8 Jan 2025 09:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736329480; cv=none; b=TgCYS3HSM4Vv2XaCHPK1XDdVLZpa+jfFTnEtLXoBltucf49OHsTqlbghUaPj6ZHM8SaQJ1eH0hbtjcxEf50QDFJNTn4gGKDJM7460un6GStwJltNDglL6f6i7m44WmkDlV1ztBh7mbpt3AsF3ArDnMPtFpdg961bG2hoJArlWok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736329480; c=relaxed/simple; bh=WgOqo56rYew6iEUDuzafyPugMgfU6khxfZtwwCMLXJk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RYuOAk3MczhWdhJy3LF/8yYlP42Xlpk30CB1NfhOe4t5I1ZPlGuxmapmo3cx5HFR+bx8xy04IZWSu6rVa8e+cvEC+IxV98VFosgwbPK8fVpx5nAMmc+vx2B9xUt3SR/p9tzOuv8zoUKGn3OoWVIAC80Fs4860P463TlpgqrZ9Ns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XQVUXubq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XQVUXubq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89847C4CEE0; Wed, 8 Jan 2025 09:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736329479; bh=WgOqo56rYew6iEUDuzafyPugMgfU6khxfZtwwCMLXJk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XQVUXubqKmqnRukOLIkr4kPA01eHXHE6TWVPt4/RNOOpXSfKyQGYdiBAcPvc41b5T 4RAbqAPW5XKjUrizu8kuEFhmiOKo/eRsBLqTyr/zVVdipSddfHPfyox1RyTCYqBrIb 0tbXTkb/pkxrxy++5h4bo2w0sDFq8NG4iGZVGQf+tNEzP43F8wQz/g1Ldl3xxmwxHT OUb7slihbDsIretynfv7wVto3ICrbCYC7ORNYRQwT2YdR/CzbDbqDdU6gmP07ir68r Un+PYxd++03EMOK47sLVMiAQQ9YPR7e26Z7oD3sKr8rHtcAm+I4AUQnkHWtpUL5ULo eOPox89CasoOg== Date: Wed, 8 Jan 2025 09:44:36 +0000 From: Simon Horman To: Eric Dumazet Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net-next] net: hsr: remove synchronize_rcu() from hsr_add_port() Message-ID: <20250108094436.GF2772@kernel.org> References: <20250107144701.503884-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107144701.503884-1-edumazet@google.com> On Tue, Jan 07, 2025 at 02:47:01PM +0000, Eric Dumazet wrote: > A synchronize_rcu() was added by mistake in commit > c5a759117210 ("net/hsr: Use list_head (and rcu) instead > of array for slave devices.") > > RCU does not mandate to observe a grace period after > list_add_tail_rcu(). > > Signed-off-by: Eric Dumazet Reviewed-by: Simon Horman