From: Jakub Kicinski <kuba@kernel.org>
To: Yeking@Red54.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
wellslutw@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH] net: ethernet: sunplus: Switch to ndo_eth_ioctl
Date: Wed, 8 Jan 2025 10:09:05 -0800 [thread overview]
Message-ID: <20250108100905.799e6112@kernel.org> (raw)
In-Reply-To: <tencent_DCCF5160376D4BCFA435D41FF333627BDF06@qq.com>
On Wed, 8 Jan 2025 14:12:38 +0000 Yeking@Red54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
>
> ndo_do_ioctl is no longer called by the device ioctl handler,
> so use ndo_eth_ioctl instead.
I presume this used to work and now it doesn't?
If so a Fixes tag pointing to the commit that broke it would
be in order.
Please also mention how you tested this. Is this something you actually
run into on real HW? Or just found by code inspection and only compile
tested?
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-08 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:12 [PATCH] net: ethernet: sunplus: Switch to ndo_eth_ioctl Yeking
2025-01-08 18:09 ` Jakub Kicinski [this message]
2025-01-09 2:05 ` [net PATCH v2] " Yeking
2025-01-09 14:03 ` Andrew Lunn
2025-01-10 2:02 ` Jakub Kicinski
2025-01-10 11:53 ` [PATCH net v3] " Yeking
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108100905.799e6112@kernel.org \
--to=kuba@kernel.org \
--cc=Yeking@Red54.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).