[PATCH net] rtase: Fix a check for error in rtase_alloc_msix()

[PATCH net] rtase: Fix a check for error in rtase_alloc_msix()

[Dan Carpenter]

The pci_irq_vector() function never returns zero.  It returns negative
error codes or a positive non-zero IRQ number.  Fix the error checking to
test for negatives.

Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
For more information about the history of IRQ returns see my blog:
https://staticthinking.wordpress.com/2023/08/07/writing-a-check-for-zero-irq-error-codes/

 drivers/net/ethernet/realtek/rtase/rtase_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 585d0b21c9e0..3bd11cb56294 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -1828,7 +1828,7 @@ static int rtase_alloc_msix(struct pci_dev *pdev, struct rtase_private *tp)
 
 	for (i = 0; i < tp->int_nums; i++) {
 		irq = pci_irq_vector(pdev, i);
-		if (!irq) {
+		if (irq < 0) {
 			pci_disable_msix(pdev);
 			return irq;
 		}
-- 
2.45.2

Re: [PATCH net] rtase: Fix a check for error in rtase_alloc_msix()

[Simon Horman]

On Wed, Jan 08, 2025 at 12:15:53PM +0300, Dan Carpenter wrote:
> The pci_irq_vector() function never returns zero.  It returns negative
> error codes or a positive non-zero IRQ number.  Fix the error checking to
> test for negatives.
> 
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net] rtase: Fix a check for error in rtase_alloc_msix()

[Kalesh Anakkur Purayil]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

On Wed, Jan 8, 2025 at 2:46 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The pci_irq_vector() function never returns zero.  It returns negative
> error codes or a positive non-zero IRQ number.  Fix the error checking to
> test for negatives.
>
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>


-- 
Regards,
Kalesh AP

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]

Re: [PATCH net] rtase: Fix a check for error in rtase_alloc_msix()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 8 Jan 2025 12:15:53 +0300 you wrote:
> The pci_irq_vector() function never returns zero.  It returns negative
> error codes or a positive non-zero IRQ number.  Fix the error checking to
> test for negatives.
> 
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> 
> [...]

Here is the summary with links:
  - [net] rtase: Fix a check for error in rtase_alloc_msix()
    https://git.kernel.org/netdev/net/c/2055272e3ae0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html