From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FCE8188713; Wed, 8 Jan 2025 10:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736333203; cv=none; b=JuNqtF4s834jODPGFxJxlmUf+yZY2vggvtguS32hdQ4xiPBmVwfwIkx63qJHtVqQEGlW2HBY6IqWPP/49EzNJTrDH9WJEKRIhXaODDRlJ2Ee77rgmeB1gw7ufLDV9O1QLr0EEqLkzsqX1R3rHh3AdCrOd7AoE48w906+w+sC/5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736333203; c=relaxed/simple; bh=sVUPS0JrI1S+Tcju6QLOXcRIhwHUS7KuoqberdrIz7U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JTd3CCbscOLJxeDiOr2DPPHqbqGQ6Izz2YPMQHUs94Sy4deCafdkFT+xQfd0ZAiZ9aZN6sZ5I1xR8Gfbv5yNVqq7+4wTDT6XZ98/O8BXwNhDbOx7MkeyDBZmT4pHCtqYuM8vpptSw1RWcfOKPFUxbnQP0Io7x8uosRB8BHZ/FsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NSR0Tjbl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NSR0Tjbl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8194AC4CEDF; Wed, 8 Jan 2025 10:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736333203; bh=sVUPS0JrI1S+Tcju6QLOXcRIhwHUS7KuoqberdrIz7U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NSR0TjblQwXhDUQyrYvXc2OOikZaWGD2DOo0bokTL1SulXwZGtjTNjreKaO/oEoiu iP12zCxeL6rOPkQxaeA4MMmkYlHU0gPPm4IW5Wvy0ed1F5vNabwIoeT8cLOtmaiBXv MqdPIfImHF9PgrqolFSE8+q3VvBM7dBwpvZAyfUOIzyEGW+H/ut8Vltu9RkSGyfbkl 9x5tN/eG0gskA8P8bZDR3wI973tBFIIF5Gh7KQ9TVzbPEiblR7lN8od3SniOL2uPrn N1vsk36/P7essz7WZcnAJAwNrsuFTPSD7axcOqhlCB4mqOuOK6LyX5Aoak0bfzIbb1 c2sknLBoS9bTQ== Date: Wed, 8 Jan 2025 10:46:38 +0000 From: Simon Horman To: Dan Carpenter Cc: Wenjia Zhang , Jan Karcher , "D. Wythe" , Tony Lu , Wen Gu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net/smc: delete pointless divide by one Message-ID: <20250108104638.GC7706@kernel.org> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 08, 2025 at 12:26:06PM +0300, Dan Carpenter wrote: > Here "buf" is a void pointer so sizeof(*buf) is one. Doing a divide > by one makes the code less readable. Delete it. > > Signed-off-by: Dan Carpenter Reviewed-by: Simon Horman