From: Jakub Kicinski <kuba@kernel.org>
To: Ivan Mikhaylov <fr0st61te@gmail.com>
Cc: Paul Fertser <fercerpav@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
Potin Lai <potin.lai@quantatw.com>,
Potin Lai <potin.lai.pt@gmail.com>,
sam@mendozajonas.com
Subject: Re: [PATCH net v2] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac_address"
Date: Wed, 8 Jan 2025 19:16:49 -0800 [thread overview]
Message-ID: <20250108191649.359d4cd7@kernel.org> (raw)
In-Reply-To: <0ecf17dd64e3f492087fea9e9e5213424fc1ce53.camel@gmail.com>
On Thu, 09 Jan 2025 00:48:07 +0300 Ivan Mikhaylov wrote:
> Common case is 1 NCSI interface for server, we tested on this one and
> works fine for us and that's the reason why we didn't catch that
> situation. Nowadays some new servers has more than one NCSI interface.
> Probably we missed that is softirq context which is obviously not a
> place for rtnl_lock/unlock. Is there any other solution about except
> delaying dev_set_mac_address in work queue? Or any suggestions about
> how to deal with that in a proper way?
Nothing obvious comes to mind, unfortunately.
But the workqueue shouldn't be too bad.
next prev parent reply other threads:[~2025-01-09 3:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 19:23 [PATCH net v2] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac_address" Jakub Kicinski
2025-01-08 20:23 ` Paul Fertser
2025-01-08 21:44 ` Jakub Kicinski
2025-01-08 21:48 ` Ivan Mikhaylov
2025-01-09 3:16 ` Jakub Kicinski [this message]
2025-01-09 14:50 ` [PATCH] net/ncsi: fix locking in Get MAC Address handling Paul Fertser
2025-01-09 16:33 ` Jakub Kicinski
[not found] ` <TYSPR04MB7868EA6003981521C1B2FDAB8E1C2@TYSPR04MB7868.apcprd04.prod.outlook.com>
2025-01-11 2:18 ` 回覆: [External] " Jakub Kicinski
2025-01-11 11:12 ` Potin Lai
2025-01-13 21:19 ` Jakub Kicinski
2025-01-14 1:56 ` Potin Lai
2025-01-14 3:04 ` Jakub Kicinski
2025-01-14 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108191649.359d4cd7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=fr0st61te@gmail.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).