From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Chenguang Zhao <zhaochenguang@kylinos.cn>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Moshe Shemesh <moshe@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2] net/mlx5: Fix variable not being completed when function returns
Date: Thu, 9 Jan 2025 08:29:15 -0800 [thread overview]
Message-ID: <20250109082915.3b011415@kernel.org> (raw)
In-Reply-To: <f6e79987-a48e-4546-b55e-ec95f7f0befe@gmail.com>
On Thu, 9 Jan 2025 15:25:36 +0200 Tariq Toukan wrote:
> > mlx5_core 0000:01:00.0: cmd_work_handler:877:(pid 3880418): failed to allocate command entry
> > INFO: task kworker/13:2:4055883 blocked for more than 120 seconds.
> > Not tainted 4.19.90-25.44.v2101.ky10.aarch64 #1
> > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> > kworker/13:2 D 0 4055883 2 0x00000228
> > Workqueue: events mlx5e_tx_dim_work [mlx5_core]
> > Call trace:
> > __switch_to+0xe8/0x150
> > __schedule+0x2a8/0x9b8
> > schedule+0x2c/0x88
> > schedule_timeout+0x204/0x478
> > wait_for_common+0x154/0x250
> > wait_for_completion+0x28/0x38
> > cmd_exec+0x7a0/0xa00 [mlx5_core]
> > mlx5_cmd_exec+0x54/0x80 [mlx5_core]
> > mlx5_core_modify_cq+0x6c/0x80 [mlx5_core]
> > mlx5_core_modify_cq_moderation+0xa0/0xb8 [mlx5_core]
> > mlx5e_tx_dim_work+0x54/0x68 [mlx5_core]
> > process_one_work+0x1b0/0x448
> > worker_thread+0x54/0x468
> > kthread+0x134/0x138
> > ret_from_fork+0x10/0x18
> >
> > Fixes: 485d65e13571 ("net/mlx5: Add a timeout to acquire the command queue semaphore")
>
> Also for the Fixes tag.
>
> Other than that:
> Acked-by: Tariq Toukan <tariqt@nvidia.com>
rewritten the commit message and applied, thanks!
next prev parent reply other threads:[~2025-01-09 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 3:00 [PATCH v2] net/mlx5: Fix variable not being completed when function returns Chenguang Zhao
2025-01-09 13:25 ` Tariq Toukan
2025-01-09 16:29 ` Jakub Kicinski [this message]
2025-01-09 16:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109082915.3b011415@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).