From: Jakub Kicinski <kuba@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Donald Hunter <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Scott Mayhew <smayhew@redhat.com>,
Yongcheng Yang <yoyang@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] lockd: add netlink control interface
Date: Thu, 9 Jan 2025 08:36:04 -0800 [thread overview]
Message-ID: <20250109083604.77ffe61d@kernel.org> (raw)
In-Reply-To: <20250108-lockd-nl-v1-1-b39f89ae0f20@kernel.org>
On Wed, 08 Jan 2025 16:00:15 -0500 Jeff Layton wrote:
> The legacy rpc.nfsd tool will set the nlm_grace_period if the NFSv4
> grace period is set. nfsdctl is missing this functionality, so add a new
> netlink control interface for lockd that it can use. For now, it only
> allows setting the grace period, and the tcp and udp listener ports.
>
> lockd currently uses module parameters and sysctls for configuration, so
> all of its settings are global. With this change, lockd now tracks these
> values on a per-net-ns basis. It will only fall back to using the global
> values if any of them are 0.
>
> Finally, as a backward compatability measure, if updating the nlm
> settings in the init_net namespace, also update the legacy global
> values to match.
Netlinky stuff LGTM, FWIW!
To encourage more doc: properties I should point out that we
render the specs on docs.kernel.org, now ;)
https://docs.kernel.org/next/networking/netlink_spec/nfsd.html
prev parent reply other threads:[~2025-01-09 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 21:00 [PATCH] lockd: add netlink control interface Jeff Layton
2025-01-09 14:10 ` cel
2025-01-09 16:36 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109083604.77ffe61d@kernel.org \
--to=kuba@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=smayhew@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=yoyang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).