From: Jakub Kicinski <kuba@kernel.org>
To: Yeking@Red54.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, wellslutw@gmail.com
Subject: Re: [net PATCH v2] net: ethernet: sunplus: Switch to ndo_eth_ioctl
Date: Thu, 9 Jan 2025 18:02:12 -0800 [thread overview]
Message-ID: <20250109180212.71e4e53c@kernel.org> (raw)
In-Reply-To: <tencent_E1D1FEF51C599BFD053CC7B4FBFEFC057A0A@qq.com>
On Thu, 9 Jan 2025 02:05:52 +0000 Yeking@Red54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
>
> ndo_do_ioctl is no longer called by the device ioctl handler,
> so use ndo_eth_ioctl instead. (found by code inspection)
>
> Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
This tag is unnecessary, Fixes tag should point to the commit which
_broke_ things.
> Fixes: a76053707dbf ("dev_ioctl: split out ndo_eth_ioctl")
Now that you added this tag you need to run get_maintainer again /
correctly on the patch and CC the authors.
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-10 2:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:12 [PATCH] net: ethernet: sunplus: Switch to ndo_eth_ioctl Yeking
2025-01-08 18:09 ` Jakub Kicinski
2025-01-09 2:05 ` [net PATCH v2] " Yeking
2025-01-09 14:03 ` Andrew Lunn
2025-01-10 2:02 ` Jakub Kicinski [this message]
2025-01-10 11:53 ` [PATCH net v3] " Yeking
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109180212.71e4e53c@kernel.org \
--to=kuba@kernel.org \
--cc=Yeking@Red54.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).