* [net-next PATCH] net: dsa: qca8k: Use of_property_present() for non-boolean properties
@ 2025-01-09 18:21 Rob Herring (Arm)
2025-01-09 19:00 ` Andrew Lunn
2025-01-10 9:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-01-09 18:21 UTC (permalink / raw)
To: Andrew Lunn, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-kernel
The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/net/dsa/qca/qca8k-8xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
index 2d56a8152420..750fc76a6e11 100644
--- a/drivers/net/dsa/qca/qca8k-8xxx.c
+++ b/drivers/net/dsa/qca/qca8k-8xxx.c
@@ -1019,7 +1019,7 @@ qca8k_setup_mdio_bus(struct qca8k_priv *priv)
of_get_phy_mode(port, &mode);
- if (of_property_read_bool(port, "phy-handle") &&
+ if (of_property_present(port, "phy-handle") &&
mode != PHY_INTERFACE_MODE_INTERNAL)
external_mdio_mask |= BIT(reg);
else
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next PATCH] net: dsa: qca8k: Use of_property_present() for non-boolean properties
2025-01-09 18:21 [net-next PATCH] net: dsa: qca8k: Use of_property_present() for non-boolean properties Rob Herring (Arm)
@ 2025-01-09 19:00 ` Andrew Lunn
2025-01-10 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2025-01-09 19:00 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel
On Thu, Jan 09, 2025 at 12:21:17PM -0600, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net-next PATCH] net: dsa: qca8k: Use of_property_present() for non-boolean properties
2025-01-09 18:21 [net-next PATCH] net: dsa: qca8k: Use of_property_present() for non-boolean properties Rob Herring (Arm)
2025-01-09 19:00 ` Andrew Lunn
@ 2025-01-10 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-01-10 9:20 UTC (permalink / raw)
To: Rob Herring
Cc: andrew, olteanv, davem, edumazet, kuba, pabeni, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 9 Jan 2025 12:21:17 -0600 you wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> drivers/net/dsa/qca/qca8k-8xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] net: dsa: qca8k: Use of_property_present() for non-boolean properties
https://git.kernel.org/netdev/net-next/c/9007d911f6d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-10 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 18:21 [net-next PATCH] net: dsa: qca8k: Use of_property_present() for non-boolean properties Rob Herring (Arm)
2025-01-09 19:00 ` Andrew Lunn
2025-01-10 9:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).