From: Simon Horman <horms@kernel.org>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Mugunthan V N <mugunthanvnm@ti.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Chintan Vankar <c-vankar@ti.com>,
Sinthu Raja <sinthu.raja@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: fix the comment regarding VLAN-aware ALE
Date: Fri, 10 Jan 2025 10:10:26 +0000 [thread overview]
Message-ID: <20250110101026.GU7706@kernel.org> (raw)
In-Reply-To: <20250109214219.123767-1-alexander.sverdlin@siemens.com>
On Thu, Jan 09, 2025 at 10:42:13PM +0100, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> In all 3 cases (cpsw, cpsw-new, am65-cpsw) ALE is being configured in
> VLAN-aware mode, while the comment states the opposite. Seems to be a typo
> copy-pasted from one driver to another. Fix the commend which has been
> puzzling some people (including me) for at least a decade.
>
> Link: https://lore.kernel.org/linux-arm-kernel/4699400.vD3TdgH1nR@localhost/
> Link: https://lore.kernel.org/netdev/0106ce78-c83f-4552-a234-1bf7a33f1ed1@kernel.org/
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-01-10 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 21:42 [PATCH net-next] net: ethernet: ti: cpsw: fix the comment regarding VLAN-aware ALE A. Sverdlin
2025-01-10 10:10 ` Simon Horman [this message]
2025-01-11 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110101026.GU7706@kernel.org \
--to=horms@kernel.org \
--cc=alexander.sverdlin@siemens.com \
--cc=andrew+netdev@lunn.ch \
--cc=c-vankar@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=sinthu.raja@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).