From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C3123AD; Sat, 11 Jan 2025 02:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736563111; cv=none; b=R1GuBcFtsX9drOlXH95I8HxJzoFws/HJCQWrF/+so2bENVFjKjqHGM3EiaI9jOMhub/IrAtjD08DckVga+Igwh1+0TfR9HMMXjUHMCqYEb0pNecl+kZKKigwAKQOr8aZvrfZw/eUkpFbOR6etvYt2GsQAwAOlStUp+hniRY2sR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736563111; c=relaxed/simple; bh=WxM5iOIWEzH+FXy9JP80oVNfFIc77UhfwsAVI7ArMaY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cp4xQPHWoRKWeCB3x+w5j0yenzSbRIvAnjCWLPkQCqt6XsO0f/pgF0vMLqB637O3MqJ80epsnLs5qg/OxwYazVpll65tLbl/VDL7z2y54gvN0f2hU6LE6Z7y8cszWj4QmUrWQoVjpyaMhzSi+R5RmpwMtlbzVFEBMFKA7QvVnTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K2J60q8W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K2J60q8W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 856CAC4CED6; Sat, 11 Jan 2025 02:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736563110; bh=WxM5iOIWEzH+FXy9JP80oVNfFIc77UhfwsAVI7ArMaY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K2J60q8WvXCoxiHVPkLLQMtoiEvUaBTmzteaJ2zpXb1UeZbL8cZ6WhZeTmkc5QU+v fGt2jBaXqtcdEvR9s9OYvR9CDAYUjc5ib6eWRq6hSbCxvATzeUNTeWjcywTCq8V9pQ aj22p/uZcIoj047iiM0vRTqE1XQIR1g/R2XXlyqLhNq4YhtxQWG/iGU+78EytqBuAM JO6GJn2ZWKogQ1ziUHGhJZtoJcBLZwpwasVZWnBqBD5BZbjrhCX1r13V8+q50y2q8M VNIDiF8RsNBogqcaxI4CNd+bFY7uGZZxRjtGANR3lTNXjzf/IGpD2MQH18ndyg5hLf 3OIkoN0OFN2zA== Date: Fri, 10 Jan 2025 18:38:29 -0800 From: Jakub Kicinski To: Chenguang Zhao Cc: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Moshe Shemesh , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v3] net/mlx5: Fix variable not being completed when function returns Message-ID: <20250110183829.5f60867f@kernel.org> In-Reply-To: <20250110032038.973659-1-zhaochenguang@kylinos.cn> References: <20250110032038.973659-1-zhaochenguang@kylinos.cn> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 Jan 2025 11:20:38 +0800 Chenguang Zhao wrote: > The cmd_work_handler function returns from the child function > cmd_alloc_index because the allocate command entry fails, > Before returning, there is no complete ent->slotted. This is already 0e2909c6bec9048f49d0c8e16887c63b50b14647 in the tree