From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us,
xiyou.wangcong@gmail.com, davem@davemloft.net,
edumazet@google.com, petrm@mellanox.com, security@kernel.org,
g1042620637@gmail.com
Subject: Re: [PATCH net v4 1/1] net: sched: fix ets qdisc OOB Indexing
Date: Sat, 11 Jan 2025 13:26:28 -0800 [thread overview]
Message-ID: <20250111132628.0defb969@kernel.org> (raw)
In-Reply-To: <CAM0EoMkRqod-MsMb60krtZ38SszwTR+3jjwE1BHPKe4m6oVArw@mail.gmail.com>
On Sat, 11 Jan 2025 16:17:45 -0500 Jamal Hadi Salim wrote:
> > Code is identical to v1 here...
>
> The inequality changed > vs >=
Ah, that works!
> > While fixing the code, could you also trim the stack trace?
> > Like this:
> >
> > UBSAN: array-index-out-of-bounds in net/sched/sch_ets.c:93:20
> > index 18446744073709551615 is out of range for type 'ets_class [16]'
> > CPU: 0 UID: 0 PID: 1275 Comm: poc Not tainted 6.12.6-dirty #17
> > Call Trace:
> > <TASK>
> > ets_class_change+0x3d6/0x3f0
> > tc_ctl_tclass+0x251/0x910
> > rtnetlink_rcv_msg+0x170/0x6f0
> > netlink_rcv_skb+0x59/0x110
> > rtnetlink_rcv+0x15/0x30
> > netlink_unicast+0x1c3/0x2b0
> > netlink_sendmsg+0x239/0x4b0
> > ____sys_sendmsg+0x3e2/0x410
> > ___sys_sendmsg+0x88/0xe0
> > __sys_sendmsg+0x69/0xd0
> >
> > the rest has no value.
>
> Still want this change?
No, it's good.
--
pw-bot: under-review
next prev parent reply other threads:[~2025-01-11 21:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 14:57 [PATCH net v4 1/1] net: sched: fix ets qdisc OOB Indexing Jamal Hadi Salim
2025-01-11 21:01 ` Jakub Kicinski
2025-01-11 21:17 ` Jamal Hadi Salim
2025-01-11 21:26 ` Jakub Kicinski [this message]
2025-01-12 23:53 ` Cong Wang
2025-01-13 10:21 ` Petr Machata
2025-01-13 11:47 ` Jamal Hadi Salim
2025-01-16 4:36 ` Cong Wang
2025-01-16 8:30 ` Paolo Abeni
2025-01-16 13:35 ` Jamal Hadi Salim
2025-01-22 18:40 ` Jamal Hadi Salim
2025-01-23 3:36 ` Jakub Kicinski
2025-01-23 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250111132628.0defb969@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=g1042620637@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=security@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).