From: Bjorn Helgaas <helgaas@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch,
pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com,
somnath.kotur@broadcom.com,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
David Wei <dw@davidwei.uk>
Subject: Re: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings
Date: Mon, 13 Jan 2025 10:01:05 -0600 [thread overview]
Message-ID: <20250113160105.GA404075@bhelgaas> (raw)
In-Reply-To: <20250113063927.4017173-10-michael.chan@broadcom.com>
On Sun, Jan 12, 2025 at 10:39:26PM -0800, Michael Chan wrote:
> From: Somnath Kotur <somnath.kotur@broadcom.com>
>
> In order to use queue_stop/queue_start to support the new Steering
> Tags, we need to free the TX ring and TX completion ring if it is a
> combined channel with TX/RX sharing the same NAPI. Otherwise
> TX completions will not have the updated Steering Tag. With that
> we can now add napi_disable() and napi_enable() during queue_stop()/
> queue_start(). This will guarantee that NAPI will stop processing
> the completion entries in case there are additional pending entries
> in the completion rings after queue_stop().
>
> There could be some NQEs sitting unprocessed while NAPI is disabled
> thereby leaving the NQ unarmed. Explictily Re-arm the NQ after
> napi_enable() in queue start so that NAPI will resume properly.
s/Explictily Re-arm/Explicitly re-arm/ (typo + capitalization)
There's a mix of "TX/RX" vs "Tx/Rx" styles in the subjects and commit
logs of this series.
next prev parent reply other threads:[~2025-01-13 16:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 6:39 [PATCH net-next 00/10] bnxt_en: Add NPAR 1.2 and TPH support Michael Chan
2025-01-13 6:39 ` [PATCH net-next 01/10] bnxt_en: Set NAPR 1.2 support when registering with firmware Michael Chan
2025-01-13 7:56 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 02/10] bnxt_en Refactor completion ring allocation logic for P5_PLUS chips Michael Chan
2025-01-13 7:59 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 03/10] bnxt_en: Refactor TX ring allocation logic Michael Chan
2025-01-13 8:02 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 04/10] bnxt_en: Refactor completion ring free routine Michael Chan
2025-01-13 8:06 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 05/10] bnxt_en: Refactor bnxt_free_tx_rings() to free per Tx ring Michael Chan
2025-01-13 8:17 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 06/10] bnxt_en: Refactor RX/RX AGG ring parameters setup for P5_PLUS Michael Chan
2025-01-13 8:27 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 07/10] bnxt_en: Pass NQ ID to the FW when allocating RX/RX AGG rings Michael Chan
2025-01-13 8:29 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 08/10] bnxt_en: Reallocate Rx completion ring for TPH support Michael Chan
2025-01-13 8:35 ` Michal Swiatkowski
2025-01-14 21:42 ` Michael Chan
2025-01-15 5:58 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings Michael Chan
2025-01-13 8:40 ` Michal Swiatkowski
2025-01-14 2:05 ` Somnath Kotur
2025-01-15 1:29 ` Michael Chan
2025-01-13 16:01 ` Bjorn Helgaas [this message]
2025-01-14 4:57 ` Somnath Kotur
2025-01-14 8:48 ` kernel test robot
2025-01-14 11:23 ` kernel test robot
2025-01-13 6:39 ` [PATCH net-next 10/10] bnxt_en: Add TPH support in BNXT driver Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113160105.GA404075@bhelgaas \
--to=helgaas@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).