From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hgani@marvell.com>, <sedara@marvell.com>, <vimleshk@marvell.com>,
<thaller@redhat.com>, <wizhao@redhat.com>, <kheib@redhat.com>,
<konguyen@redhat.com>, <horms@kernel.org>,
<einstein.xue@synaxg.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>
Subject: Re: [PATCH net v6 1/4] octeon_ep: update tx/rx stats locally for persistence
Date: Mon, 13 Jan 2025 19:36:50 -0800 [thread overview]
Message-ID: <20250113193650.1b3d6f55@kernel.org> (raw)
In-Reply-To: <20250110122730.2551863-2-srasheed@marvell.com>
On Fri, 10 Jan 2025 04:27:27 -0800 Shinas Rasheed wrote:
> @@ -991,33 +991,30 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb,
> static void octep_get_stats64(struct net_device *netdev,
> struct rtnl_link_stats64 *stats)
> {
> - u64 tx_packets, tx_bytes, rx_packets, rx_bytes;
> struct octep_device *oct = netdev_priv(netdev);
> int q;
>
> + oct->iface_tx_stats.pkts = 0;
> + oct->iface_tx_stats.octs = 0;
> + oct->iface_rx_stats.pkts = 0;
> + oct->iface_rx_stats.octets = 0;
> + for (q = 0; q < oct->num_ioq_stats; q++) {
> + oct->iface_tx_stats.pkts += oct->stats_iq[q].instr_completed;
> + oct->iface_tx_stats.octs += oct->stats_iq[q].bytes_sent;
> + oct->iface_rx_stats.pkts += oct->stats_oq[q].packets;
> + oct->iface_rx_stats.octets += oct->stats_oq[q].bytes;
> + }
The new approach is much better, but you can't use oct->iface_* as
intermediate storage. There is no exclusive locking on this function,
multiple processes can be executing this function in parallel.
Overwriting each others updates to oct->iface_tx_stats etc.
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-14 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 12:27 [PATCH net v6 0/4] Fix race conditions in ndo_get_stats64 Shinas Rasheed
2025-01-10 12:27 ` [PATCH net v6 1/4] octeon_ep: update tx/rx stats locally for persistence Shinas Rasheed
2025-01-14 3:36 ` Jakub Kicinski [this message]
2025-01-10 12:27 ` [PATCH net v6 2/4] octeon_ep: remove firmware stats fetch in ndo_get_stats64 Shinas Rasheed
2025-01-10 12:27 ` [PATCH net v6 3/4] octeon_ep_vf: update tx/rx stats locally for persistence Shinas Rasheed
2025-01-10 12:27 ` [PATCH net v6 4/4] octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64 Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113193650.1b3d6f55@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=einstein.xue@synaxg.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=thaller@redhat.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).