From: Jakub Kicinski <kuba@kernel.org>
To: Joey Lu <a0987203069@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, ychuang3@nuvoton.com, schung@nuvoton.com,
yclu4@nuvoton.com, peppe.cavallaro@st.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v7 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family
Date: Tue, 14 Jan 2025 15:33:23 -0800 [thread overview]
Message-ID: <20250114153323.527d4f63@kernel.org> (raw)
In-Reply-To: <20250113055434.3377508-4-a0987203069@gmail.com>
On Mon, 13 Jan 2025 13:54:34 +0800 Joey Lu wrote:
> + regmap_write(bsp_priv->regmap,
> + macid == 0 ? NVT_REG_SYS_GMAC0MISCR : NVT_REG_SYS_GMAC1MISCR, reg);
This is a pretty long line and you do it twice, so save the address
to a temp variable, pls
> +MODULE_LICENSE("GPL v2");
checkpatch insists:
WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-14 23:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 5:54 [PATCH net-next v7 0/3] Add support for Nuvoton MA35D1 GMAC Joey Lu
2025-01-13 5:54 ` [PATCH net-next v7 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC Joey Lu
2025-01-13 5:54 ` [PATCH net-next v7 2/3] arm64: dts: nuvoton: Add Ethernet nodes Joey Lu
2025-01-13 5:54 ` [PATCH net-next v7 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family Joey Lu
2025-01-14 1:49 ` Paul Menzel
2025-01-14 2:16 ` Andrew Lunn
2025-01-14 2:21 ` Paul Menzel
2025-01-14 10:29 ` Yanteng Si
2025-01-14 23:35 ` Jakub Kicinski
[not found] ` <2cf758f2-529e-4ccd-9dc1-18fc29ad5ac0@gmail.com>
2025-01-15 9:22 ` Paul Menzel
2025-01-15 11:05 ` Joey Lu
2025-01-14 23:33 ` Jakub Kicinski [this message]
2025-01-15 9:09 ` Joey Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114153323.527d4f63@kernel.org \
--to=kuba@kernel.org \
--cc=a0987203069@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).