From: Jakub Kicinski <kuba@kernel.org>
To: Yeking@Red54.com
Cc: andrew+netdev@lunn.ch, arnd@arndb.de, davem@davemloft.net,
edumazet@google.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, wellslutw@gmail.com
Subject: Re: [PATCH net v5] net: ethernet: sunplus: Switch to ndo_eth_ioctl
Date: Tue, 14 Jan 2025 18:11:31 -0800 [thread overview]
Message-ID: <20250114181131.16c1072f@kernel.org> (raw)
In-Reply-To: <tencent_8CF8A72C708E96B9C7DC1AF96FEE19AF3D05@qq.com>
On Mon, 13 Jan 2025 09:41:56 +0000 Yeking@Red54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
>
> The device ioctl handler no longer calls ndo_do_ioctl, but calls
> ndo_eth_ioctl to handle mii ioctls since commit a76053707dbf
> ("dev_ioctl: split out ndo_eth_ioctl"). However, sunplus still used
> ndo_do_ioctl when it was introduced. So switch to ndo_eth_ioctl. (found
> by code inspection)
>
> Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
It only occurred to me now that if we're fixing the initial commit
the PHY IOCTLs simply weren't available since day 1, so this is more
of a new feature than a bug fix. We'll apply it for v6.14, sorry for
the indecisiveness.
next prev parent reply other threads:[~2025-01-15 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 13:29 [PATCH net v4] net: ethernet: sunplus: Switch to ndo_eth_ioctl Yeking
2025-01-11 1:57 ` Jakub Kicinski
2025-01-13 9:41 ` [PATCH net v5] " Yeking
2025-01-15 2:11 ` Jakub Kicinski [this message]
2025-01-15 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114181131.16c1072f@kernel.org \
--to=kuba@kernel.org \
--cc=Yeking@Red54.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).