From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Furong Xu <0x1207@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
xfr@outlook.com
Subject: Re: [PATCH net-next v2 3/3] net: stmmac: Optimize cache prefetch in RX path
Date: Tue, 14 Jan 2025 18:20:00 -0800 [thread overview]
Message-ID: <20250114182000.4ca2c433@kernel.org> (raw)
In-Reply-To: <Z4bzuToquRAMfvvu@LQ3V64L9R2>
On Tue, 14 Jan 2025 15:31:05 -0800 Joe Damato wrote:
> > @@ -5525,6 +5521,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
> >
> > dma_sync_single_for_cpu(priv->device, buf->addr,
> > buf1_len, dma_dir);
> > + prefetch(page_address(buf->page) + buf->page_offset);
>
> Minor nit: I've seen in other drivers authors using net_prefetch.
> Probably not worth a re-roll just for something this minor.
Let's respin. I don't know how likely stmmac is to be integrated into
an SoC with 64B cachelines these days, but since you caught this -
why not potentially save someone from investigating this later..
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-15 2:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 14:20 [PATCH net-next v2 0/3] net: stmmac: RX performance improvement Furong Xu
2025-01-13 14:20 ` [PATCH net-next v2 1/3] net: stmmac: Switch to zero-copy in non-XDP RX path Furong Xu
2025-01-13 14:20 ` [PATCH net-next v2 2/3] net: stmmac: Set page_pool_params.max_len to a precise size Furong Xu
2025-01-13 14:20 ` [PATCH net-next v2 3/3] net: stmmac: Optimize cache prefetch in RX path Furong Xu
2025-01-14 23:31 ` Joe Damato
2025-01-15 2:20 ` Jakub Kicinski [this message]
2025-01-15 2:33 ` Furong Xu
2025-01-15 17:27 ` Joe Damato
2025-01-13 14:27 ` [PATCH net-next v2 0/3] net: stmmac: RX performance improvement Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114182000.4ca2c433@kernel.org \
--to=kuba@kernel.org \
--cc=0x1207@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).