netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
	Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v1 net-next 0/3] dev: Covnert dev_change_name() to per-netns RTNL.
Date: Wed, 15 Jan 2025 18:55:42 +0900	[thread overview]
Message-ID: <20250115095545.52709-1-kuniyu@amazon.com> (raw)

Patch 1 adds a missing netdev_rename_lock in dev_change_name()
and Patch 2 removes unnecessary devnet_rename_sem there.

Patch 3 replaces RTNL with rtnl_net_lock() in dev_ifsioc(),
and now dev_change_name() is always called under per-netns RTNL.

Given it's close to -rc8 and Patch 1 touches the trivial unlikely
path, can Patch 1 go into net-next ?  Otherwise I'll post Patch 2 & 3
separately in the next cycle.


Kuniyuki Iwashima (3):
  dev: Acquire netdev_rename_lock before restoring dev->name in
    dev_change_name().
  dev: Remove devnet_rename_sem.
  dev: Hold rtnl_net_lock() for dev_ifsioc().

 net/core/dev.c            | 25 ++++++-------------------
 net/core/dev_ioctl.c      | 26 +++++++++++++++++---------
 net/core/rtnl_net_debug.c | 15 +++------------
 3 files changed, 26 insertions(+), 40 deletions(-)

-- 
2.39.5 (Apple Git-154)


             reply	other threads:[~2025-01-15  9:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15  9:55 Kuniyuki Iwashima [this message]
2025-01-15  9:55 ` [PATCH v1 net-next 1/3] dev: Acquire netdev_rename_lock before restoring dev->name in dev_change_name() Kuniyuki Iwashima
2025-01-15 10:22   ` Eric Dumazet
2025-01-15  9:55 ` [PATCH v1 net-next 2/3] dev: Remove devnet_rename_sem Kuniyuki Iwashima
2025-01-15 10:26   ` Eric Dumazet
2025-01-15  9:55 ` [PATCH v1 net-next 3/3] dev: Hold rtnl_net_lock() for dev_ifsioc() Kuniyuki Iwashima
2025-01-15 10:32   ` Eric Dumazet
2025-01-17  1:30 ` [PATCH v1 net-next 0/3] dev: Covnert dev_change_name() to per-netns RTNL patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250115095545.52709-1-kuniyu@amazon.com \
    --to=kuniyu@amazon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).