From: Jakub Kicinski <kuba@kernel.org>
To: Yeking@Red54.com
Cc: arnd@arndb.de, davem@davemloft.net, edumazet@google.com,
gregkh@linuxfoundation.org, horms@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, prarit@redhat.com, vkuznets@redhat.com
Subject: Re: [PATCH net v2] net: appletalk: Drop aarp_send_probe_phase1()
Date: Wed, 15 Jan 2025 14:06:29 -0800 [thread overview]
Message-ID: <20250115140629.1c37c8a2@kernel.org> (raw)
In-Reply-To: <tencent_EE9140075A979E58EBB03FA7E7DEF6831F07@qq.com>
On Mon, 13 Jan 2025 09:44:51 +0000 Yeking@Red54.com wrote:
> void aarp_probe_network(struct atalk_iface *atif)
> {
> - if (atif->dev->type == ARPHRD_LOCALTLK ||
> - atif->dev->type == ARPHRD_PPP)
> - aarp_send_probe_phase1(atif);
> - else {
> + if (atif->dev->type != ARPHRD_LOCALTLK &&
> + atif->dev->type != ARPHRD_PPP) {
> unsigned int count;
You assert this is our only option, so why leave the if () around
at all?
nit: subject prefix should be "PATCH net-next v2"
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-15 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 12:27 [net PATCH] net: appletalk: Drop aarp_send_probe_phase1() Yeking
2025-01-11 2:24 ` Jakub Kicinski
2025-01-13 9:44 ` [PATCH net v2] " Yeking
2025-01-15 22:06 ` Jakub Kicinski [this message]
2025-01-17 1:41 ` [PATCH net-next v3] " Yeking
2025-01-20 10:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115140629.1c37c8a2@kernel.org \
--to=kuba@kernel.org \
--cc=Yeking@Red54.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prarit@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).