From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0803114B959; Wed, 15 Jan 2025 22:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736978791; cv=none; b=b+opEFiG5B2NKW2o9QxvCp2VUiCzmjgc9Se1U6TWnG0zVOWJUsMpaxEQ0jftYVJO4vYZc/5WVicdQ2PuhYW6Q4hglunBR2yYiyTrjEiXp/ZiGUVxOncIgB9QT9eDlcHZRw+GDLNaKJ/XajNTZJds15lP6fFuf7pNWfdYnLWMB34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736978791; c=relaxed/simple; bh=OrqNIeP5Lsyj0QQbwXP6V6pMaJ3YCATIJ7eT3LsJKjY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W6P3j+LuFmgMfJI4ynacHK39CsQzXSLS88HgCih/ZMwqyEminTbtKymJEYgo7dTG9NDvkjYlVx0+oLcxiMgq0trtOoAutDR+d9u7H8ZuDdT6I0OzJVzRtBzoEkWOcFkRt33Fv92M4PHhCUewpTt4FHwYdjm9xQKWDx7ik9CW1Rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YVSU6PHR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YVSU6PHR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A8C8C4CED1; Wed, 15 Jan 2025 22:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736978790; bh=OrqNIeP5Lsyj0QQbwXP6V6pMaJ3YCATIJ7eT3LsJKjY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YVSU6PHRIDStXuNKnHl2KTyfrHshzJEZShltiqasWXphcmY5a9+nupHRYSsDGASgX kWFIKZ29qq1Fi4qfjTZlQ3sbyS77iCrSU+pIMqUQVKW4mRGVsDU9HoNyhZw+i/g4p9 HNw0n9QWcLgjnMiKAdp1YjQdJgSaXnyzwHSK0sDG3T3ErDqVODVYcStboqRNCnv59l Tn+QCotMBhpycvQrKgS4/Zx1RicI8ZGVygB8bWJfUtCkIHXPEV/t23VP477kGD8l9P rn57XY6MIQqoXm6yY5atramIWE9xDWLXH+oiyqbwT3GqZuYARmhJGkYXFTvjdBVVdJ DCerY39s2kFIQ== Date: Wed, 15 Jan 2025 14:06:29 -0800 From: Jakub Kicinski To: Yeking@Red54.com Cc: arnd@arndb.de, davem@davemloft.net, edumazet@google.com, gregkh@linuxfoundation.org, horms@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, prarit@redhat.com, vkuznets@redhat.com Subject: Re: [PATCH net v2] net: appletalk: Drop aarp_send_probe_phase1() Message-ID: <20250115140629.1c37c8a2@kernel.org> In-Reply-To: References: <20250110182435.6b811abe@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 13 Jan 2025 09:44:51 +0000 Yeking@Red54.com wrote: > void aarp_probe_network(struct atalk_iface *atif) > { > - if (atif->dev->type == ARPHRD_LOCALTLK || > - atif->dev->type == ARPHRD_PPP) > - aarp_send_probe_phase1(atif); > - else { > + if (atif->dev->type != ARPHRD_LOCALTLK && > + atif->dev->type != ARPHRD_PPP) { > unsigned int count; You assert this is our only option, so why leave the if () around at all? nit: subject prefix should be "PATCH net-next v2" -- pw-bot: cr