From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 ENETC PF
Date: Wed, 15 Jan 2025 18:41:05 -0800 [thread overview]
Message-ID: <20250115184105.139aed9c@kernel.org> (raw)
In-Reply-To: <PAXPR04MB8510B52B7D27640C557680B4881A2@PAXPR04MB8510.eurprd04.prod.outlook.com>
On Thu, 16 Jan 2025 02:24:10 +0000 Wei Fang wrote:
> > Why create full ops for something this trivial?
>
> We add enetc_pf_hw_ops to implement different hardware ops
> for different chips. So that they can be called in common functions.
> Although the change is minor, it is consistent with the original
> intention of adding enetc_pf_hw_ops.
In other words you prefer ops.
Now imagine you have to refactor such piece of code in 10 drivers
and each of them has 2 layers of indirect ops like you do.
Unnecessary complexity.
next prev parent reply other threads:[~2025-01-16 2:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 8:22 [PATCH v2 net-next 00/13] Add more feautues for ENETC v4 - round 2 Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 02/13] net: enetc: add command BD ring support for i.MX95 ENETC Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 03/13] net: enetc: move generic MAC filterng interfaces to enetc-core Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 04/13] net: enetc: add MAC filter for i.MX95 ENETC PF Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 05/13] net: enetc: add debugfs interface to dump MAC filter Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 06/13] net: enetc: make enetc_set_rxfh() and enetc_get_rxfh() reusable Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 ENETC PF Wei Fang
2025-01-15 22:00 ` Jakub Kicinski
2025-01-16 2:24 ` Wei Fang
2025-01-16 2:41 ` Jakub Kicinski [this message]
2025-01-16 4:03 ` Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 08/13] net: enetc: enable RSS feature by default Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 09/13] net: enetc: move generic VLAN filter interfaces to enetc-core Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 10/13] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 11/13] net: enetc: add VLAN filtering support for i.MX95 ENETC PF Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 12/13] net: enetc: add loopback " Wei Fang
2025-01-13 8:22 ` [PATCH v2 net-next 13/13] MAINTAINERS: add new file ntmp.h to ENETC driver Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115184105.139aed9c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).