From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, willemb@google.com, matttbe@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests/net: packetdrill: make tcp buf limited timing tests benign
Date: Thu, 16 Jan 2025 06:58:35 -0800 [thread overview]
Message-ID: <20250116065835.1cc1eaac@kernel.org> (raw)
In-Reply-To: <678904353ca7e_3710bc294ef@willemb.c.googlers.com.notmuch>
On Thu, 16 Jan 2025 08:05:57 -0500 Willem de Bruijn wrote:
> Jakub Kicinski wrote:
> > The following tests are failing on debug kernels:
> >
> > tcp_tcp_info_tcp-info-rwnd-limited.pkt
> > tcp_tcp_info_tcp-info-sndbuf-limited.pkt
> >
> > with reports like:
> >
> > assert 19000 <= tcpi_sndbuf_limited <= 21000, tcpi_sndbuf_limited; \
> > AssertionError: 18000
> >
> > and:
> >
> > assert 348000 <= tcpi_busy_time <= 360000, tcpi_busy_time
> > AssertionError: 362000
> >
> > Extend commit 912d6f669725 ("selftests/net: packetdrill: report benign
> > debug flakes as xfail") to cover them.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
>
> Thanks.
>
> I see that we'll still have a few flakes on dbg. Perhaps one total
> failure a day. From the following.
>
> tcp-close-close-local-close-then-remote-fin-pkt
> tcp-ecn-ecn-uses-ect0-pkt
> tcp-eor-no-coalesce-retrans-pkt
> tcp-slow-start-slow-start-after-win-update-pkt
Argh, I missed the two above, I had the ignored cases filtered out
when I was looking :(
> tcp-sack-sack-route-refresh-ip-tos-pkt
> tcp-ts-recent-reset-tsval-pkt
> tcp-zerocopy-closed-pkt
>
> We'll take a look after this change whether we can make these
> more resilient. But likely also allow-list or even xfail for
> everything in dbg.
Okay.
next prev parent reply other threads:[~2025-01-16 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 23:21 [PATCH net-next] selftests/net: packetdrill: make tcp buf limited timing tests benign Jakub Kicinski
2025-01-16 13:05 ` Willem de Bruijn
2025-01-16 14:58 ` Jakub Kicinski [this message]
2025-01-17 11:21 ` Matthieu Baerts
2025-01-17 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116065835.1cc1eaac@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).