From: Jakub Kicinski <kuba@kernel.org>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: Shinas Rasheed <srasheed@marvell.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <hgani@marvell.com>,
<sedara@marvell.com>, <vimleshk@marvell.com>,
<thaller@redhat.com>, <wizhao@redhat.com>, <kheib@redhat.com>,
<konguyen@redhat.com>, <horms@kernel.org>,
<einstein.xue@synaxg.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for persistence
Date: Thu, 16 Jan 2025 16:27:11 -0800 [thread overview]
Message-ID: <20250116162711.71d74e10@kernel.org> (raw)
In-Reply-To: <Z4klGpVVsxOPR3RZ@lzaremba-mobl.ger.corp.intel.com>
On Thu, 16 Jan 2025 16:26:18 +0100 Larysa Zaremba wrote:
> > + for (q = 0; q < oct->num_ioq_stats; q++) {
> > + tx_packets += oct->stats_iq[q].instr_completed;
> > + tx_bytes += oct->stats_iq[q].bytes_sent;
> > + rx_packets += oct->stats_oq[q].packets;
> > + rx_bytes += oct->stats_oq[q].bytes;
>
> Correct me if I am wrong, but the interface-wide statistics should not change
> when changing queue number. In such case maybe it would be a good idea to
> always iterate over all OCTEP_MAX_QUEUES queues when calculating the stats.
Good catch!
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-17 0:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 8:38 [PATCH net v8 0/4] Fix race conditions in ndo_get_stats64 Shinas Rasheed
2025-01-16 8:38 ` [PATCH net v8 1/4] octeon_ep: remove firmware stats fetch " Shinas Rasheed
2025-01-16 15:44 ` Larysa Zaremba
2025-01-16 8:38 ` [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for persistence Shinas Rasheed
2025-01-16 15:26 ` Larysa Zaremba
2025-01-17 0:27 ` Jakub Kicinski [this message]
2025-01-17 4:11 ` [EXTERNAL] " Shinas Rasheed
2025-01-17 5:49 ` Shinas Rasheed
2025-01-16 8:38 ` [PATCH net v8 3/4] octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64 Shinas Rasheed
2025-01-16 15:42 ` Larysa Zaremba
2025-01-16 8:38 ` [PATCH net v8 4/4] octeon_ep_vf: update tx/rx stats locally for persistence Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116162711.71d74e10@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=einstein.xue@synaxg.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=thaller@redhat.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).