From: Jakub Kicinski <kuba@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: Paul Fertser <fercerpav@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
horms@kernel.org, pabeni@redhat.com, edumazet@google.com,
davem@davemloft.net, sam@mendozajonas.com,
Ivan Mikhaylov <fr0st61te@gmail.com>
Subject: Re: [PATCH] net/ncsi: Fix NULL pointer derefence if CIS arrives before SP
Date: Fri, 17 Jan 2025 14:43:32 -0800 [thread overview]
Message-ID: <20250117144332.7ea38896@kernel.org> (raw)
In-Reply-To: <97ec8df6-0690-4158-be44-ef996746d734@linux.ibm.com>
On Fri, 17 Jan 2025 15:05:24 -0600 Eddie James wrote:
> I am able to reproduce the panic at will, and unfortunately your patch
> does not prevent the issue.
>
> However I suspect this issue may be unique to my set up, so my patch may
> not be necessary. I found that I had some user space issues. Fixing
> userspace prevented this issue.
The kernel shouldn't crash even if user space is buggy..
Maybe we can apply a simplified patch to return an error if !np?
next prev parent reply other threads:[~2025-01-17 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 19:41 [PATCH] net/ncsi: Fix NULL pointer derefence if CIS arrives before SP Eddie James
2025-01-14 22:49 ` Jakub Kicinski
2025-01-15 23:01 ` Paul Fertser
2025-01-17 21:05 ` Eddie James
2025-01-17 22:43 ` Jakub Kicinski [this message]
2025-01-20 14:00 ` Paul Fertser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117144332.7ea38896@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=eajames@linux.ibm.com \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=fr0st61te@gmail.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).