From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09E21195811 for ; Fri, 17 Jan 2025 23:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737154842; cv=none; b=dPQ3h07IACnfcMSGUUAPHG6a5AwOhelq6dKZ12HOlooWnKayZjy8D5smAzuFlSjWXNGG5HL0hVbtS2wgvn70OemOr7940TlVBbSRoBkSROpSV0W99Ny+g7vS96Ttnv0Jbeye0N2NzgiLAsoLPF5OF5yFK9hov07q7BI46Bt7c2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737154842; c=relaxed/simple; bh=EMmsz4Guk7K0RltZtX/TLPY7POqiLi0oydB9aoWegtI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lrpjLuWIPMMEs/SHM2miuW1B8cVAZ2XmyOpUohD//igOZ43hjjfCXtfAMVXrnMUv9OrrbRwneAPEZCeN6dQ5eLSOUg4+beq76ROWlWuPcK2dRbyatevRTxoMo0Py5754nPQwWmVzpgd5JFZNC8WoPYzvvwJv6l2yYAsZ3MflpjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eeByrOAy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eeByrOAy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22138C4CEDD; Fri, 17 Jan 2025 23:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737154839; bh=EMmsz4Guk7K0RltZtX/TLPY7POqiLi0oydB9aoWegtI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eeByrOAy8QVzXaLyB3aS0KO/1PCs/GW9QGMoRJQYSPhFyAop/GgvDJsGBDk3PbrfF 1MSohtRZz6vxUVGPo8dROir17S+G1Xfe5CuUdVc5heMWdFKCRA5AHPIrMosXbXIIPK fn2nqJ8Ui+S1ilPJCN9RPxWjhlbF3x2AjWmgIClinWWYZW/DLmi1nolR43AwZGfZvh kigqmVBGk3sc63iplGnLLBZ3KjheNsFesYk0bJxTJypBw7CDLxWC8n49EskjGLAAyX Hh4csrcQJeWaHBS8Gwn5V6KU16rbr1rUVBOO6QeYi6xf+D3YpDncaxjr9RVCkhp8zC sTaCCgHAZJPMg== Date: Fri, 17 Jan 2025 15:00:38 -0800 From: Jakub Kicinski To: Eric Dumazet Cc: "David S . Miller" , Paolo Abeni , netdev@vger.kernel.org, Simon Horman , Kuniyuki Iwashima , eric.dumazet@gmail.com, syzbot+85ff1051228a04613a32@syzkaller.appspotmail.com Subject: Re: [PATCH net-next] net: destroy dev->lock later in free_netdev() Message-ID: <20250117150038.1f009a20@kernel.org> In-Reply-To: <20250117224626.1427577-1-edumazet@google.com> References: <20250117224626.1427577-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 17 Jan 2025 22:46:26 +0000 Eric Dumazet wrote: > syzbot complained that free_netdev() was calling netif_napi_del() > after dev->lock mutex has been destroyed. > > This fires a warning for CONFIG_DEBUG_MUTEXES=y builds. > > Move mutex_destroy(&dev->lock) near the end of free_netdev(). Reviewed-by: Jakub Kicinski