From: Vladimir Oltean <olteanv@gmail.com>
To: Tristram.Ha@microchip.com
Cc: andrew@lunn.ch, maxime.chevallier@bootlin.com,
Woojung.Huh@microchip.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: microchip: Add SGMII port support to KSZ9477 switch
Date: Sat, 18 Jan 2025 03:26:32 +0200 [thread overview]
Message-ID: <20250118012632.qf4jmwz2bry43qqe@skbuf> (raw)
In-Reply-To: <DM3PR11MB873695894DC7B99A15357CCBECE52@DM3PR11MB8736.namprd11.prod.outlook.com>
On Sat, Jan 18, 2025 at 12:59:25AM +0000, Tristram.Ha@microchip.com wrote:
> Some of the register definitions are not present in the XPCS driver so I
> need to add them.
Not a problem.
> Some register bits programmed by the XPCS driver do not have effect.
Like what?
> Actually KSZ9477 has a bug in SGMII implementation and needs a software
> workaround. I am not sure if the generic XCPS driver can cover that.
What kind of bug? In the integration or in the IP itself? Anyway,
SJA1105 had what you could call an integration bug too, and that's why
nxp_sja1105_sgmii_pma_config() exists. I am not sure either until you
are more specific.
It is a widespread hardware IP. I don't think it's unreasonable to have
a central driver for it with many quirks, as long as they're well documented
and clearly understood.
next prev parent reply other threads:[~2025-01-18 1:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 2:47 [PATCH net-next v2] net: dsa: microchip: Add SGMII port support to KSZ9477 switch Tristram.Ha
2025-01-14 16:09 ` Vladimir Oltean
2025-01-14 16:53 ` Vladimir Oltean
2025-01-15 10:10 ` Maxime Chevallier
2025-01-17 0:56 ` Tristram.Ha
2025-01-17 13:36 ` Andrew Lunn
2025-01-18 0:59 ` Tristram.Ha
2025-01-18 1:26 ` Vladimir Oltean [this message]
2025-01-18 4:07 ` Tristram.Ha
2025-01-18 20:00 ` Andrew Lunn
2025-01-21 0:28 ` Tristram.Ha
2025-01-21 3:08 ` Tristram.Ha
2025-01-17 16:18 ` Vladimir Oltean
2025-01-17 0:51 ` Tristram.Ha
-- strict thread matches above, loose matches on Subject: below --
2025-05-07 0:09 Tristram.Ha
2025-05-07 7:44 ` Maxime Chevallier
2025-05-07 8:31 ` Russell King (Oracle)
2025-05-07 8:54 ` Maxime Chevallier
2025-05-08 1:41 ` Tristram.Ha
2025-05-10 0:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250118012632.qf4jmwz2bry43qqe@skbuf \
--to=olteanv@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox