From: Jakub Kicinski <kuba@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
netdev@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
linux-kernel@vger.kernel.org,
Shannon Nelson <shannon.nelson@amd.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v4 5/6] net: xilinx: axienet: Get coalesce parameters from driver state
Date: Sat, 18 Jan 2025 17:18:38 -0800 [thread overview]
Message-ID: <20250118171838.215e58ec@kernel.org> (raw)
In-Reply-To: <20250116232954.2696930-6-sean.anderson@linux.dev>
On Thu, 16 Jan 2025 18:29:53 -0500 Sean Anderson wrote:
> +/**
> + * axienet_cr_params() - Extract coalesce parameters from the CR
> + * @lp: Device private data
> + * @cr: The control register to parse
> + * @count: Number of packets before an interrupt
> + * @usec: Idle time (in usec) before an interrupt
> + */
> +static void axienet_coalesce_params(struct axienet_local *lp, u32 cr,
> + u32 *count, u32 *usec)
W=1 builds hit:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:277: warning: expecting prototype for axienet_cr_params(). Prototype was for axienet_coalesce_params() instead
I'll apply the first 2 patches, 2nd one is almost a fix..
The rest may need to wait until after the merge window, unless Linus
tags -rc8.
next prev parent reply other threads:[~2025-01-19 1:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 23:29 [PATCH net-next v4 0/6] net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM Sean Anderson
2025-01-16 23:29 ` [PATCH net-next v4 1/6] net: xilinx: axienet: Add some symbolic constants for IRQ delay timer Sean Anderson
2025-01-16 23:29 ` [PATCH net-next v4 2/6] net: xilinx: axienet: Report an error for bad coalesce settings Sean Anderson
2025-01-16 23:29 ` [PATCH net-next v4 3/6] net: xilinx: axienet: Combine CR calculation Sean Anderson
2025-01-16 23:29 ` [PATCH net-next v4 4/6] net: xilinx: axienet: Support adjusting coalesce settings while running Sean Anderson
2025-01-16 23:29 ` [PATCH net-next v4 5/6] net: xilinx: axienet: Get coalesce parameters from driver state Sean Anderson
2025-01-19 1:18 ` Jakub Kicinski [this message]
2025-01-16 23:29 ` [PATCH net-next v4 6/6] net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM Sean Anderson
2025-01-19 1:19 ` [PATCH net-next v4 0/6] " Jakub Kicinski
2025-01-21 15:59 ` Sean Anderson
2025-01-19 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250118171838.215e58ec@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=sean.anderson@linux.dev \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).